-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
Test Miri on all tier 1 targets #117167
Copy link
Copy link
Closed
Labels
A-CIArea: Our Github Actions CIArea: Our Github Actions CIA-miriArea: The miri toolArea: The miri toolT-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.Relevant to the infrastructure team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
A-CIArea: Our Github Actions CIArea: Our Github Actions CIA-miriArea: The miri toolArea: The miri toolT-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.Relevant to the infrastructure team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
We currently run Miri on tests a few select targets:
rust/src/ci/docker/host-x86_64/x86_64-gnu-tools/checktools.sh
Lines 27 to 32 in c905fd2
However, that's not all tier 1 targets, so e.g. x86_64-apple-darwin is not covered, and today's nightly contains a Miri where some APIs are broken on x86_64-apple-darwin.
It'd be great if we could run (some) Miri tests on all tier 1 targets. Note that Miri tests can be run on any host so this does not require running checktools.sh on more hosts. However we'd probably not want to test all targets on all hosts, so we need some way in checktools.sh to determine which host we are on, and spread the test jobs across the hosts. Also, depending on how tight our time budget is here, we might want to not run all tests -- just running the "pass" tests should generally be sufficient and can save a bunch of time.
Cc @rust-lang/infra -- in particular, (a) how can I check for the host in checktools.sh, and (b) how tight is our time budget for the "tools" builders?