run-make tests on Windows (wezterm + recent PowerShell 7) triggers Windows Error Reporting error dialogues

[jieyouxu]

Some intended-to-fail run-make tests on Windows will spam a bunch of Windows Error Reporting (WER) error dialogues because failing to find DLLs and such. However, nobody else ran into this because it has three necessary conditions to trigger:

1. You need to be using a terminal emulator that's not Windows Terminal™.
   • Windows Terminal has a bug Windows terminal does not show missing dll popup microsoft/terminal#9788 (probably still not fixed?) where it ate the WER error dialogues.
   • ... and I recently switched to wezterm.
2. You also need to be using a sufficiently new version of PowerShell.
   • My system's default powershell version was PowerShell 5 (probably same for other people using current versions of Windows 11).
   • Recent PowerShell 7 versions seems to have fixed a bug with PowerShell (or rather, changed the behavior of) also not properly displaying WER error dialogues like cmd.exe or File Explorer: Configurable behavior on critical error: message on Error stream or pop-up dialog PowerShell/PowerShell#16468.
   • ... and I recently tried to use PowerShell v7.
3. Oh, and you have to be using "native" Windows msvc (not msys2 or windows-gnu) and running the run-make test suite. Not many contributors do in the first place.

compiletest has a mitigation for this:

rust/src/tools/compiletest/src/runtest.rs

Lines 70 to 80 in b8bb296

	// Tell Windows to not show any UI on errors (such as terminating abnormally).
	// This is important for running tests, since some of them use abnormal
	// termination by design. This mode is inherited by all child processes.
	unsafe {
	let old_mode = SetErrorMode(SEM_NOGPFAULTERRORBOX); // read inherited flags
	let old_mode = THREAD_ERROR_MODE(old_mode);
	SetErrorMode(old_mode | SEM_NOGPFAULTERRORBOX);
	let r = f();
	SetErrorMode(old_mode);
	r
	}

However, this seems to be missing a SEM_FAILCRITICALERRORS flag.

[jieyouxu]

EDIT: it's actually because how run-make tests are spawned, they are not guarded with disable_error_reporting.
EDIT2: yep that's exactly it

[jieyouxu]

I had to get a recording of what this looks like

Incredible.Windows.Error.Reporting.mp4