-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
run-make test failures when building rust-with rpath disabled #140738
Copy link
Copy link
Open
Labels
A-run-makeArea: port run-make Makefiles to rmake.rsArea: port run-make Makefiles to rmake.rsA-test-infraArea: test infrastructure (may span bootstrap/compiletest/more)Area: test infrastructure (may span bootstrap/compiletest/more)C-bugCategory: This is a bug.Category: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
A-run-makeArea: port run-make Makefiles to rmake.rsArea: port run-make Makefiles to rmake.rsA-test-infraArea: test infrastructure (may span bootstrap/compiletest/more)Area: test infrastructure (may span bootstrap/compiletest/more)C-bugCategory: This is a bug.Category: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Similar to #140299, we're seeing some
run-maketests failing to run due to missinglibrustc_driverwhen building withrpathdisabled:Tests that fail:
The root cause is that these tests either:
Command::new(env_var("RUSTC"))instead using therustc()wrapper provided by run-make-support, orcargo()wrapper fromrun-make-support, which doesn't set the runtime library path (e.g. LD_LIBRARY_PATH) likerustc()does.To reproduce in a clean tree:
./config --disable-rpath python x.py test --force-rerun tests/run-make/{broken-pipe-no-ice,compiler-builtins,rustc-crates-on-stable}Originally reproduced on beta (973ec11), still happens on latest master (71b68da).