TEST_BENCH does nothing

[brson]

make tips says that TEST_BENCH=1 will run benchmarks but it is not true. Are we ever running benchmarks?

[kmcallister]

Isn't it PLEASE_BENCH=1 now?

[estsauver]

It looks to me like neither the TEST_BENCH nor the PLEASE_BENCH commands are actually used anywhere. If the PLEASE_BENCH flag is set then the TEST_BENCH flag is set to --bench, but I don't know if those flags are used anywhere else. My grepping results are below.

Earls-MacBook-Pro:rust earljstsauver$ ag TEST_BENCH -C 3
mk/tests.mk
38-  TESTARGS += --ignored
39-endif
40-
41:TEST_BENCH =
42-
43-# Arguments to the cfail/rfail/rpass/bench tests
44-ifdef CFG_VALGRIND
45-  CTEST_RUNTOOL = --runtool "$(CFG_VALGRIND)"
46:  TEST_BENCH =
47-endif
48-
49-ifdef PLEASE_BENCH
50:  TEST_BENCH = --bench
51-endif
52-
53-# Arguments to the perf tests
Earls-MacBook-Pro:rust earljstsauver$ ag PLEASE_BENCH -C 3
Makefile.in
69-#
70-#   * `TESTNAME=...` - Specify the name of tests to run
71-#   * `CHECK_IGNORED=1` - Run normally-ignored tests
72:#   * `PLEASE_BENCH=1` - Run crate benchmarks (enable `--bench` flag)
73-#
74-#   * `CFG_ENABLE_VALGRIND=1` - Run tests under valgrind
75-#   * `VALGRIND_COMPILE=1` - Run the compiler itself under valgrind

mk/tests.mk
46-  TEST_BENCH =
47-endif
48-
49:ifdef PLEASE_BENCH
50-  TEST_BENCH = --bench
51-endif
52-

[nagisa]

I used PLEASE_BENCH successfully not too long ago.

[lilyball]

It looks like PLEASE_BENCH was broken in 611ef49, which removed all the ratcheting stuff.