-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
Separate "make check" and "make commit" targets #2943
Copy link
Copy link
Closed
Labels
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Milestone
Metadata
Metadata
Assignees
Labels
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
In the meeting today, we agreed it would be a good idea for the part of tidy that checks that FIXMEs have issue numbers to run in a separate target, called
commitor something, so that you can add FIXMEs while working without having to add issue numbers until you check in. So the workflow would be:make check... [repeat ad infinitum], and once you're ready to commit, runmake commitbefore committing.The only catch is that people have to remember to run
make commit...