-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
Errant edge to krate node #36168
Copy link
Copy link
Closed
Labels
A-incr-compArea: Incremental compilationArea: Incremental compilationT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone
Metadata
Metadata
Assignees
Labels
A-incr-compArea: Incremental compilationArea: Incremental compilationT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
I noticed when checking the
syntex-syntaxnode that, when I add a private fn into the crate module, it invalidates the krate-0 module. This is because the metadata includes edges to the immediate children. This seems bad, but then there is also a read whenever we read an inlined item from crate X of the crate root, which means that this winds up triggering bad reuse. I am trying to figure out why this read arises and remove it, but I'd also like to remove the dependency of metadata.