-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
annotate-snippet emitter: Deal with multispans in macros correctly #61810
Copy link
Copy link
Closed
Labels
A-diagnosticsArea: Messages for errors, warnings, and lintsArea: Messages for errors, warnings, and lintsE-help-wantedCall for participation: Help is requested to fix this issue.Call for participation: Help is requested to fix this issue.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
A-diagnosticsArea: Messages for errors, warnings, and lintsArea: Messages for errors, warnings, and lintsE-help-wantedCall for participation: Help is requested to fix this issue.Call for participation: Help is requested to fix this issue.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Part of #59346
To properly handle macro spans in diagnostics output, we have to decouple some
emitter.rscode first.Relevant
FIXME:rust/src/librustc_errors/annotate_snippet_emitter_writer.rs
Line 38 in 57a3300
emitter.rsequivalent:rust/src/librustc_errors/emitter.rs
Line 792 in 0e4a56b
fix_multispans_in_std_macrosmethod from
EmitterWriterso that the code can be re-used inAnnotateSnippetEmitterWriterwithout duplicating it.