-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
Passing --disable-per-crate-search to rustdoc disables search altogether #66816
Copy link
Copy link
Closed
Labels
C-bugCategory: This is a bug.Category: This is a bug.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
C-bugCategory: This is a bug.Category: This is a bug.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
docs.rs ran into this this morning, see rust-lang/docs.rs#497.
This seems to have been caused by #66298, which disabled the search bar by default. The logic to reenable search was a little buggy -
getSearchElement()looks for an element with the 'search' id, but that ID is not set when--disable-per-crate-searchis enabled.Steps to replicate:
cc @QuietMisdreavus @GuillaumeGomez