-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
Don't (ab)use TyKind::Error when not planning to emit error #70866
Copy link
Copy link
Closed
Labels
A-type-systemArea: Type systemArea: Type systemC-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
A-type-systemArea: Type systemArea: Type systemC-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
cc #70551 @eddyb
Currently, it appears we are misusing
TyKind::Error(andConst::Error) in these places, which we should refactor:fixed by Fix abuses of tykind::err #70870
rust/src/librustc_typeck/check/wfcheck.rs
Line 710 in 6dee5f1
fixed by Fix abuses of tykind::err #70870
rust/src/librustc_typeck/check/wfcheck.rs
Line 715 in 6dee5f1
fixed by Fix abuses of tykind::err #70870
rust/src/librustc_typeck/lib.rs
Line 383 in 6dee5f1
fixed by Fix abuses of tykind::err #70870
rust/src/librustc_typeck/variance/constraints.rs
Line 319 in 6dee5f1
fixed by De-abuse TyKind::Error in pattern type checking #70932
rust/src/librustc_typeck/check/pat.rs
Lines 1428 to 1435 in 42abbd8
fixed by Use trait_object_dummy_self instead of err #71938
rust/src/librustc_typeck/check/closure.rs
Line 180 in 93dc97a
fixed by ty/walk: iterate
GenericArgs instead ofTys. #70164rust/src/librustc_trait_selection/traits/select.rs
Line 3079 in 6dee5f1
fixed by De-abuse TyKind::Error in exhaustiveness checking #71930
rust/src/librustc_mir_build/hair/pattern/_match.rs
Line 900 in 9fed360