Span debugger#12087

sanxiyn · 2014-02-07T10:53:35Z

No description provided.

sanxiyn · 2014-02-07T10:55:40Z

Before:

span.rs:2     let _ = || ();
                    ^~~~~~~
span.rs:3     [0].len();
              ^~~~~~~~~~
span.rs:4     (0);
              ^~~~

After:

span.rs:2     let _ = || ();
                      ^~~~~
span.rs:3     [0].len();
              ^~~~~~~~~
span.rs:4     (0);
              ^~~

huonw · 2014-02-07T11:00:09Z

src/librustc/front/show_span.rs

Could we have a comment about what this is doing?

(What the file is doing, that is; I know what the import is doing. :P )

sanxiyn · 2014-02-07T11:15:31Z

Added some comments.

Add new lint: `ref_as_ptr` Fixes rust-lang#10130 Added new lint `ref_as_ptr` that checks for conversions from references to pointers and suggests using `std::ptr::from_{ref, mut}` instead. The name is different than suggested in the issue (`as_ptr_cast`) since there were some other lints with similar names (`ptr_as_ptr`, `borrow_as_ptr`) and I wanted to follow the convention. Note that this lint conflicts with the `borrow_as_ptr` lint in the sense that it recommends changing `&foo as *const _` to `std::ptr::from_ref(&foo)` instead of `std::ptr::addr_of!(foo)`. Personally, I think the former is more readable and, in contrast to `addr_of` macro, can be also applied to temporaries (cf. rust-lang#9884). --- changelog: New lint: [`ref_as_ptr`] [rust-lang#12087](rust-lang/rust-clippy#12087)

It's very old (added in rust-lang#12087). It's strange, and it's not clear what its use cases are. It only works with the crate root file because it runs before expansion. I suspect it won't be missed.

…iler-errors Remove `-Zshow-span`. It's very old (added in rust-lang#12087). It's strange, and it's not clear what its use cases are. It only works with the crate root file because it runs before expansion. I suspect it won't be missed. r? `@estebank`

Rollup merge of rust-lang#133847 - nnethercote:rm-Z-show-span, r=compiler-errors Remove `-Zshow-span`. It's very old (added in rust-lang#12087). It's strange, and it's not clear what its use cases are. It only works with the crate root file because it runs before expansion. I suspect it won't be missed. r? `@estebank`

sanxiyn added 2 commits February 7, 2014 19:50

Span debugger

104002b

Correct span for ExprFnBlock, ExprMethodCall, ExprParen

5109d1a

huonw reviewed Feb 7, 2014
View reviewed changes

Add comments to span debugger

e5463b9

bors added a commit that referenced this pull request Feb 7, 2014

auto merge of #12087 : sanxiyn/rust/show-span, r=huonw

c3ccaac

bors closed this Feb 7, 2014

bors merged commit e5463b9 into rust-lang:master Feb 7, 2014

sanxiyn deleted the show-span branch February 9, 2014 05:58

nnethercote mentioned this pull request Dec 4, 2024

Remove -Zshow-span. #133847

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Span debugger#12087