Conversation
The update in rust-lang#128677 was accidentally reverted in rust-lang#128962.
|
|
Why didn't rustbot alert on modified submodules in that PR? :/// @bors r+ |
|
@bors rollup=never (mirroring the original pr) |
I suspect it's because the force push diff didn't include it: https://github.com/rust-lang/rust/compare/11cf5e808b75fdc9db5c54b2420f130a7254219f..70e0f69632591add54bc1e4d625e7bbb9fa02095.diff |
|
Yeah, I'm surprised given that usually rustbot is quite assiduous at whining about that sort of thing. |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (a73bc4a): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (primary -3.1%, secondary 0.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary 2.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 751.393s -> 751.349s (-0.01%) |
|
Results continue to look like bimodality. |
The update in #128677 was accidentally reverted in #128962.
Fixes #129064
r? nikic