Skip to content

crashes: more tests#129228

Merged
bors merged 1 commit intorust-lang:masterfrom
matthiaskrgr:oopsie
Aug 19, 2024
Merged

crashes: more tests#129228
bors merged 1 commit intorust-lang:masterfrom
matthiaskrgr:oopsie

Conversation

@matthiaskrgr
Copy link
Copy Markdown
Member

@matthiaskrgr matthiaskrgr commented Aug 18, 2024

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 18, 2024
jieyouxu
jieyouxu approved these changes Aug 18, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jieyouxu
Copy link
Copy Markdown
Member

jieyouxu commented Aug 18, 2024

@bors r+ rollup=iffy (crashes tests)

@bors
Copy link
Copy Markdown
Collaborator

bors commented Aug 18, 2024

📌 Commit c001a3b has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 18, 2024
@bors
Auto merge of rust-lang#129228 - matthiaskrgr:oopsie, r=jieyouxu
c7719a9 
crashes: more tests

r? `@jieyouxu`
@bors
Copy link
Copy Markdown
Collaborator

bors commented Aug 18, 2024

⌛ Testing commit c001a3b with merge c7719a9...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Copy Markdown
Collaborator

bors commented Aug 18, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 18, 2024
@jieyouxu
Copy link
Copy Markdown
Member

jieyouxu commented Aug 18, 2024

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2024
@matthiaskrgr
Copy link
Copy Markdown
Member Author

matthiaskrgr commented Aug 18, 2024

right I was wondering if that would happen 😅
marked test as //@ only-x86_64
@bors r=jieyouxu

@bors
Copy link
Copy Markdown
Collaborator

bors commented Aug 18, 2024

📌 Commit b8531e8 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 18, 2024
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Aug 18, 2024
@jieyouxu
Rollup merge of rust-lang#129228 - matthiaskrgr:oopsie, r=jieyouxu
2e243da 
crashes: more tests

r? `@jieyouxu`
@jieyouxu jieyouxu mentioned this pull request Aug 18, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 18, 2024
@bors
Auto merge of rust-lang#129242 - jieyouxu:rollup-1yhzl81, r=jieyouxu
88a596a 
Rollup of 4 pull requests

Successful merges:

 - rust-lang#128084 (Suggest adding Result return type for associated method in E0277.)
 - rust-lang#129187 (bootstrap: fix clean's remove_dir_all implementation)
 - rust-lang#129208 (Fix order of normalization and recursion in const folding.)
 - rust-lang#129228 (crashes: more tests)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 18, 2024
@bors
Auto merge of rust-lang#129228 - matthiaskrgr:oopsie, r=jieyouxu
2062938 
crashes: more tests

r? `@jieyouxu`
@bors
Copy link
Copy Markdown
Collaborator

bors commented Aug 18, 2024

⌛ Testing commit b8531e8 with merge 2062938...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Copy Markdown
Collaborator

bors commented Aug 18, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 18, 2024
@matthiaskrgr
Copy link
Copy Markdown
Member Author

matthiaskrgr commented Aug 18, 2024

weird that this would not crash on windows but on linux??

@matthiaskrgr
Copy link
Copy Markdown
Member Author

matthiaskrgr commented Aug 18, 2024

@bors r=jieyouxu

@bors
Copy link
Copy Markdown
Collaborator

bors commented Aug 18, 2024

📌 Commit 5fe70af has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2024
@bors
Copy link
Copy Markdown
Collaborator

bors commented Aug 19, 2024

⌛ Testing commit 5fe70af with merge 804be74...

@bors
Copy link
Copy Markdown
Collaborator

bors commented Aug 19, 2024

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 804be74 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 19, 2024
@bors bors merged commit 804be74 into rust-lang:master Aug 19, 2024
@rustbot rustbot added this to the 1.82.0 milestone Aug 19, 2024
@rust-timer
Copy link
Copy Markdown
Collaborator

rust-timer commented Aug 19, 2024

Finished benchmarking commit (804be74): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 1.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 4.7% [4.7%, 4.7%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.5% [-2.5%, -2.5%] 1
All ❌✅ (primary) - - 0

Cycles

Results (secondary -2.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.3% [-2.4%, -2.1%] 2
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 751.219s -> 751.973s (0.10%)
Artifact size: 339.13 MiB -> 339.15 MiB (0.00%)

@matthiaskrgr matthiaskrgr deleted the oopsie branch January 25, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.82.0

Development

Successfully merging this pull request may close these issues.

6 participants

@matthiaskrgr @jieyouxu @bors @rust-log-analyzer @rust-timer @rustbot