Skip to content

Disable tests/ui/associated-consts/issue-93775.rs on windows msvc#134372

Merged
bors merged 1 commit intorust-lang:masterfrom
jieyouxu:disable-flaky-test
Dec 16, 2024
Merged

Disable tests/ui/associated-consts/issue-93775.rs on windows msvc#134372
bors merged 1 commit intorust-lang:masterfrom
jieyouxu:disable-flaky-test

Conversation

@jieyouxu
Copy link
Copy Markdown
Member

@jieyouxu jieyouxu commented Dec 16, 2024

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Dec 16, 2024

r? @Noratrieb

rustbot has assigned @Noratrieb.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 16, 2024
@jieyouxu jieyouxu mentioned this pull request Dec 16, 2024
Merged
Noratrieb
Noratrieb approved these changes Dec 16, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Noratrieb Noratrieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the horrors

@Noratrieb
Copy link
Copy Markdown
Member

Noratrieb commented Dec 16, 2024

@bors r+ rollup

@bors
Copy link
Copy Markdown
Collaborator

bors commented Dec 16, 2024

📌 Commit 1cde4a4 has been approved by Noratrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 16, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 16, 2024
@bors
Auto merge of rust-lang#134374 - matthiaskrgr:rollup-2tbbrxq, r=matth…
eedc229 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#134314 (Make sure to use normalized ty for unevaluated const in default struct value)
 - rust-lang#134342 (crashes: more tests)
 - rust-lang#134357 (Fix `trimmed_def_paths` ICE in the function ptr comparison lint)
 - rust-lang#134369 (Update spelling of "referring")
 - rust-lang#134372 (Disable `tests/ui/associated-consts/issue-93775.rs` on windows msvc)

Failed merges:

 - rust-lang#134365 (Rename `rustc_mir_build::build` to `builder`)

r? `@ghost`
`@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 16, 2024
@rust-timer
Unrolled build for rust-lang#134372
153e133 
Rollup merge of rust-lang#134372 - jieyouxu:disable-flaky-test, r=Noratrieb

Disable `tests/ui/associated-consts/issue-93775.rs` on windows msvc

This test seems to be quite flaky. See:

- rust-lang#132111
- rust-lang#133432
@bors bors merged commit 0a77972 into rust-lang:master Dec 16, 2024
@rustbot rustbot added this to the 1.85.0 milestone Dec 16, 2024
@jieyouxu jieyouxu deleted the disable-flaky-test branch December 16, 2024 11:06
@jieyouxu jieyouxu added the A-testsuite Area: The testsuite used to check the correctness of rustc label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Noratrieb Noratrieb Noratrieb approved these changes

Assignees

@Noratrieb Noratrieb

Labels

A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.85.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jieyouxu @rustbot @Noratrieb @bors