Crate level into allowed targets

[jdonszelmann]

r? @scrabsha

@rustbot blocked on #146389

[rustbot]

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

[rustbot]

Failed to set assignee to scrabsha: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

[jdonszelmann]

I think @scrabsha is the best reviewer for this PR.

@bors r? @oli-obk

If you feel like it, delegate to @scrabsha

[rustbot]

oli-obk is not on the review rotation at the moment.
They may take a while to respond.

[oli-obk]

@bors delegate=scrabsha

[bors]

✌️ @scrabsha, you can now approve this pull request!

If @oli-obk told you to "r=me" after making some further change, please make that change, then do @bors r=@oli-obk

[jdonszelmann]

@rustbot review

[rustbot]

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[scrabsha]

I should have noticed this when writing my PR 😭

@bors r+ meow

[bors]

📌 Commit f56eb06 has been approved by scrabsha

It is now in the queue for this repository.

[bors]

⌛ Testing commit f56eb06 with merge ddaf123...

[bors]

☀️ Test successful - checks-actions
Approved by: scrabsha
Pushing ddaf123 to master...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 60a5372 (parent) -> ddaf123 (this PR)

Test differences

Show 11 test diffs

Stage 2

• [run-make] tests/run-make/compressed-debuginfo-zstd: ignore (ignored if LLVM wasn't build with zstd for ELF section compression (we want LLVM/LLD to be built with zstd support)) -> pass (J0)

Additionally, 10 doctest diffs were found. These are ignored, as they are noisy.

Job group index

• J0: x86_64-gnu-nopt

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard ddaf12390d3ffb7d5ba74491a48f3cd528e5d777 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. x86_64-rust-for-linux: 3989.6s -> 2578.3s (-35.4%)
2. pr-check-1: 2055.1s -> 1353.3s (-34.1%)
3. pr-check-2: 2927.7s -> 2188.8s (-25.2%)
4. x86_64-gnu-miri: 5879.0s -> 4531.7s (-22.9%)
5. aarch64-apple: 6578.2s -> 5141.0s (-21.8%)
6. test-various: 5963.5s -> 4724.6s (-20.8%)
7. armhf-gnu: 5937.8s -> 4769.3s (-19.7%)
8. x86_64-gnu-tools: 4618.5s -> 3735.5s (-19.1%)
9. dist-x86_64-apple: 8022.1s -> 6533.3s (-18.6%)
10. x86_64-gnu-stable: 8489.8s -> 6955.7s (-18.1%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (ddaf123): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 2.7%, secondary 0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.7%	[2.7%, 2.7%]	1
Regressions ❌ (secondary)	3.1%	[1.0%, 6.4%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.9%	[-2.2%, -1.6%]	4
All ❌✅ (primary)	2.7%	[2.7%, 2.7%]	1

Cycles

Results (primary 2.2%, secondary 1.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.2%	[2.2%, 2.2%]	1
Regressions ❌ (secondary)	1.6%	[1.6%, 1.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.2%	[2.2%, 2.2%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.675s -> 473.077s (-0.13%)
Artifact size: 390.15 MiB -> 390.10 MiB (-0.01%)