(EXPERIMENT) compiletest: Don't set TARGET for non-run-make tests#147896
(EXPERIMENT) compiletest: Don't set TARGET for non-run-make tests#147896Zalathar wants to merge 2 commits intorust-lang:masterfrom
TARGET for non-run-make tests#147896Conversation
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
|
@bors try jobs=dist-i586-gnu-i586-i686-musl |
This comment has been minimized.
This comment has been minimized.
(EXPERIMENT) compiletest: Don't set `TARGET` for non-run-make tests try-job: dist-i586-gnu-i586-i686-musl
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@bors try jobs=dist-i586-gnu-i586-i686-musl |
(EXPERIMENT) compiletest: Don't set `TARGET` for non-run-make tests try-job: dist-i586-gnu-i586-i686-musl
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors try cancel |
|
Try build cancelled. Cancelled workflows: |
|
@bors try jobs=dist-i586-gnu-i586-i686-musl |
(EXPERIMENT) compiletest: Don't set `TARGET` for non-run-make tests try-job: dist-i586-gnu-i586-i686-musl
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
💔 Test for 1f51c82 failed: CI. Failed jobs:
|
|
OK, this confirms that i586 still requires special treatment to avoid breaking CI. But we should be able to just use |
|
|
This comment has been minimized.
This comment has been minimized.
There are a few tests that were trying to skip i586 targets via the `TARGET` environment variable instead, so better to just add support for the directive.
|
@bors try jobs=dist-i586-gnu-i586-i686-musl |
(EXPERIMENT) compiletest: Don't set `TARGET` for non-run-make tests try-job: dist-i586-gnu-i586-i686-musl
This comment has been minimized.
This comment has been minimized.
|
💔 Test for 4bedb6d failed: CI. Failed jobs:
|
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
|
Flaky failure (503). @bors try jobs=dist-i586-gnu-i586-i686-musl |
(EXPERIMENT) compiletest: Don't set `TARGET` for non-run-make tests try-job: dist-i586-gnu-i586-i686-musl
This comment has been minimized.
This comment has been minimized.
|
💔 Test for e65848f failed: CI. Failed jobs:
|
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
|
@bors try jobs=dist-i586-gnu-i586-i686-musl |
This comment has been minimized.
This comment has been minimized.
(EXPERIMENT) compiletest: Don't set `TARGET` for non-run-make tests try-job: dist-i586-gnu-i586-i686-musl
|
Now that this works, I'll close this PR and open a fresh one for review. |
There seem to be a few UI tests that use environment variable
TARGETto avoid problems on i586, but we should probably just permit and use//@ ignore-i586instead.The run-make runner explicitly sets
TARGETon its own, so run-make tests shouldn't be affected.This PR is currently just for running try jobs; it's not intended for merging (yet).
r? ghost