Point to the item that is incorrectly annotated with #[diagnostic::on_const]#149627
Merged
bors merged 1 commit intorust-lang:mainfrom Dec 5, 2025
Merged
Point to the item that is incorrectly annotated with #[diagnostic::on_const]#149627bors merged 1 commit intorust-lang:mainfrom
#[diagnostic::on_const]#149627bors merged 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_passes/src/check_attr.rs |
rustbot
added
A-attributes
Contributor
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
estebank
reviewed
Dec 4, 2025
Comment on lines
+21
to
+23
| LL | | ||
| LL | impl const PartialEq for Foo { | ||
| | ---------------------------- not a trait impl |
Contributor
There was a problem hiding this comment.
We'll need to fix this to specify on const impls that the annotation only works on non-const ones, but that can be done in a follow up PR.
bors
added a commit
that referenced
this pull request
Dec 4, 2025
Rollup of 9 pull requests Successful merges: - #147224 (Emscripten: Turn wasm-eh on by default) - #149405 (Recover on misspelled item keyword) - #149443 (Tidying up UI tests [6/N]) - #149524 (Move attribute safety checking to attribute parsing) - #149593 (powf, powi: point out SNaN non-determinism) - #149605 (Use branch name instead of HEAD when unshallowing) - #149612 (Apply the `bors` environment also to the `outcome` job) - #149623 (Don't require a normal tool build of clippy/rustfmt when running their test steps) - #149627 (Point to the item that is incorrectly annotated with `#[diagnostic::on_const]`) r? `@ghost` `@rustbot` modify labels: rollup
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Dec 5, 2025
Rollup of 9 pull requests Successful merges: - rust-lang/rust#147224 (Emscripten: Turn wasm-eh on by default) - rust-lang/rust#149405 (Recover on misspelled item keyword) - rust-lang/rust#149443 (Tidying up UI tests [6/N]) - rust-lang/rust#149524 (Move attribute safety checking to attribute parsing) - rust-lang/rust#149593 (powf, powi: point out SNaN non-determinism) - rust-lang/rust#149605 (Use branch name instead of HEAD when unshallowing) - rust-lang/rust#149612 (Apply the `bors` environment also to the `outcome` job) - rust-lang/rust#149623 (Don't require a normal tool build of clippy/rustfmt when running their test steps) - rust-lang/rust#149627 (Point to the item that is incorrectly annotated with `#[diagnostic::on_const]`) r? `@ghost` `@rustbot` modify labels: rollup
Kobzol
pushed a commit
to Kobzol/rustc_codegen_gcc
that referenced
this pull request
Dec 21, 2025
Rollup of 9 pull requests Successful merges: - rust-lang/rust#147224 (Emscripten: Turn wasm-eh on by default) - rust-lang/rust#149405 (Recover on misspelled item keyword) - rust-lang/rust#149443 (Tidying up UI tests [6/N]) - rust-lang/rust#149524 (Move attribute safety checking to attribute parsing) - rust-lang/rust#149593 (powf, powi: point out SNaN non-determinism) - rust-lang/rust#149605 (Use branch name instead of HEAD when unshallowing) - rust-lang/rust#149612 (Apply the `bors` environment also to the `outcome` job) - rust-lang/rust#149623 (Don't require a normal tool build of clippy/rustfmt when running their test steps) - rust-lang/rust#149627 (Point to the item that is incorrectly annotated with `#[diagnostic::on_const]`) r? `@ghost` `@rustbot` modify labels: rollup
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 3, 2026
…, r=estebank Distinguish error message for `#[diagnostic::on_const]` on const trait impls context: rust-lang#149627 (comment) Sorry for the delay between receiving the review and submitting this patch. I'll ask the original proposer to review it. r? estebank
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 3, 2026
…, r=estebank Distinguish error message for `#[diagnostic::on_const]` on const trait impls context: rust-lang#149627 (comment) Sorry for the delay between receiving the review and submitting this patch. I'll ask the original proposer to review it. r? estebank
rust-timer
added a commit
that referenced
this pull request
Feb 4, 2026
Rollup merge of #152054 - lapla-cogito:diag_const_trait_impl, r=estebank Distinguish error message for `#[diagnostic::on_const]` on const trait impls context: #149627 (comment) Sorry for the delay between receiving the review and submitting this patch. I'll ask the original proposer to review it. r? estebank
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #149606
r? estebank