Add freeze file times on Windows#149718
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Jan 12, 2026
Merged
Conversation
rustbot
added
O-windows
Collaborator
|
r? @ChrisDenton rustbot has assigned @ChrisDenton. Use |
4 tasks
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
|
Sorry for the delay, this looks great thanks! Could you squish your commits into one? Then it should be ready to merge. |
tguichaoua
force-pushed
the
windows_freeze_file_times
branch
from
c2b6a4c to
d772c3d
Compare
Collaborator
|
Member
|
Thanks! @bors r+ |
rust-bors
bot
added
S-waiting-on-bors
Contributor
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 11, 2026
…Denton Add freeze file times on Windows This PR add two new methods on [OpenOptionsExt](https://doc.rust-lang.org/stable/std/os/windows/fs/trait.OpenOptionsExt.html) in order to not change the "last access time" and "last write time" of the file on Windows. - Tracking Issue: rust-lang#149715 - ACP: rust-lang/libs-team#708
rust-bors bot
added a commit
that referenced
this pull request
Jan 11, 2026
Rollup of 7 pull requests Successful merges: - #147938 (Add const cloning of slices and tests) - #149718 (Add freeze file times on Windows) - #150438 (Remove mentions of debootstrap and chroots from the m68k-unknown-none-elf platform support doc) - #150906 (Simplify `#[eii]` macro using methods on ecx) - #150938 (Port `#[collapse_debuginfo]` to the new attribute parsing system) - #150953 (std: sys: fs: uefi: Implement copy) - #150964 (Completely list all unparsed attributes) Failed merges: - #150972 (Rename EII attributes slightly (being consistent in naming things foreign items, not extern items)) r? @ghost
rust-bors bot
added a commit
that referenced
this pull request
Jan 12, 2026
Rollup of 9 pull requests Successful merges: - #147938 (Add const cloning of slices and tests) - #149718 (Add freeze file times on Windows) - #150438 (Remove mentions of debootstrap and chroots from the m68k-unknown-none-elf platform support doc) - #150790 (feat: invisible character help string) - #150906 (Simplify `#[eii]` macro using methods on ecx) - #150938 (Port `#[collapse_debuginfo]` to the new attribute parsing system) - #150953 (std: sys: fs: uefi: Implement copy) - #150964 (Completely list all unparsed attributes) - #150975 (ui: add test for normalizing const projections with assoc const equality) Failed merges: - #150972 (Rename EII attributes slightly (being consistent in naming things foreign items, not extern items)) r? @ghost
rust-timer
added a commit
that referenced
this pull request
Jan 12, 2026
Rollup merge of #149718 - windows_freeze_file_times, r=ChrisDenton Add freeze file times on Windows This PR add two new methods on [OpenOptionsExt](https://doc.rust-lang.org/stable/std/os/windows/fs/trait.OpenOptionsExt.html) in order to not change the "last access time" and "last write time" of the file on Windows. - Tracking Issue: #149715 - ACP: rust-lang/libs-team#708
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 11, 2026
…lmann,kivooeo add regression test for OpenOptionsExt downstream compat Following up on #153491, which added a warning comment there, but no automated guardrail to prevent another breaking change like #149718 This adds a simple windows-only ui test that manually implements `OpenOptionsExt`. That way, if someone accidentally adds another required method to the trait, we catch it before it reaches stable and breaks downstream crates like Tokio again. Closes #153486
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Apr 13, 2026
…, r=jdonszelmann,kivooeo add regression test for OpenOptionsExt downstream compat Following up on rust-lang#153491, which added a warning comment there, but no automated guardrail to prevent another breaking change like rust-lang#149718 This adds a simple windows-only ui test that manually implements `OpenOptionsExt`. That way, if someone accidentally adds another required method to the trait, we catch it before it reaches stable and breaks downstream crates like Tokio again. Closes rust-lang#153486
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Apr 13, 2026
…, r=jdonszelmann,kivooeo add regression test for OpenOptionsExt downstream compat Following up on rust-lang#153491, which added a warning comment there, but no automated guardrail to prevent another breaking change like rust-lang#149718 This adds a simple windows-only ui test that manually implements `OpenOptionsExt`. That way, if someone accidentally adds another required method to the trait, we catch it before it reaches stable and breaks downstream crates like Tokio again. Closes rust-lang#153486
rust-timer
added a commit
that referenced
this pull request
Apr 13, 2026
Rollup merge of #155140 - Vastargazing:open-options-ext-test, r=jdonszelmann,kivooeo add regression test for OpenOptionsExt downstream compat Following up on #153491, which added a warning comment there, but no automated guardrail to prevent another breaking change like #149718 This adds a simple windows-only ui test that manually implements `OpenOptionsExt`. That way, if someone accidentally adds another required method to the trait, we catch it before it reaches stable and breaks downstream crates like Tokio again. Closes #153486
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Apr 13, 2026
…zelmann,kivooeo add regression test for OpenOptionsExt downstream compat Following up on rust-lang/rust#153491, which added a warning comment there, but no automated guardrail to prevent another breaking change like rust-lang/rust#149718 This adds a simple windows-only ui test that manually implements `OpenOptionsExt`. That way, if someone accidentally adds another required method to the trait, we catch it before it reaches stable and breaks downstream crates like Tokio again. Closes rust-lang/rust#153486
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add two new methods on OpenOptionsExt in order to not change the "last access time" and "last write time" of the file on Windows.