Skip to content

Create GPU target notification group#154430

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
apiraino:create-gpu-target-notif-group
Mar 27, 2026
Merged

Create GPU target notification group#154430
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
apiraino:create-gpu-target-notif-group

Conversation

@apiraino
Copy link
Copy Markdown
Contributor

Creating the notification group for the newly created GPU target (see mcp#960)

I'm following these steps.

(feel free to suggest a better wording)

r? @jieyouxu

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 26, 2026

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 26, 2026
@apiraino apiraino force-pushed the create-gpu-target-notif-group branch from 041525e to 3b0fdd2 Compare March 26, 2026 16:17
Copy link
Copy Markdown
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with a tiny nit :) Thanks

View changes since this review

@jieyouxu
Copy link
Copy Markdown
Member

(No idea what's up with the diff in the review suggestion)

@apiraino apiraino requested a review from jieyouxu March 26, 2026 16:21
@jieyouxu
Copy link
Copy Markdown
Member

Thanks
@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Mar 26, 2026

📌 Commit 12e6f0e has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 26, 2026
@jieyouxu
Copy link
Copy Markdown
Member

Sorry I have to try this out
@bors r-

@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 26, 2026
@jieyouxu
Copy link
Copy Markdown
Member

@bors squash

@rust-bors

This comment has been minimized.

* Create GPU target notification group
* Update triagebot.toml

Co-authored-by: 许杰友 Jieyou Xu (Joe) <39484203+jieyouxu@users.noreply.github.com>
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Mar 26, 2026

🔨 2 commits were squashed into 5efde4b.

@rust-bors rust-bors bot force-pushed the create-gpu-target-notif-group branch from 12e6f0e to 5efde4b Compare March 26, 2026 16:33
@jieyouxu
Copy link
Copy Markdown
Member

Nice. Ah it (of course) washes out the "verified", but meh not really a big deal.
@bors r+

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Mar 26, 2026

📌 Commit 5efde4b has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 26, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 26, 2026
…roup, r=jieyouxu

Create GPU target notification group

Creating the notification group for the newly created GPU target (see [mcp#960](https://rust-lang.zulipchat.com/#narrow/channel/233931-t-compiler.2Fmajor-changes/topic/Create.20a.20GPU.20notification.20group.20compiler-team.23960/near/568629680))

I'm following these [steps](rust-lang#133334).

(feel free to suggest a better wording)

r? @jieyouxu
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 26, 2026
…roup, r=jieyouxu

Create GPU target notification group

Creating the notification group for the newly created GPU target (see [mcp#960](https://rust-lang.zulipchat.com/#narrow/channel/233931-t-compiler.2Fmajor-changes/topic/Create.20a.20GPU.20notification.20group.20compiler-team.23960/near/568629680))

I'm following these [steps](rust-lang#133334).

(feel free to suggest a better wording)

r? @jieyouxu
rust-bors bot pushed a commit that referenced this pull request Mar 27, 2026
Rollup of 7 pull requests

Successful merges:

 - #152457 (Pass -pg to linker when using -Zinstrument-mcount)
 - #154031 (Remove divergence check from check_expr_array)
 - #154418 (move many tests out of `ui/unsafe`)
 - #153662 (Suggest fully qualified path on method name collision)
 - #153675 (simd_add/sub/mul/neg: document overflow behavior)
 - #154110 (Change "error finalizing incremental compilation" text and emit it as a note, not a warning)
 - #154430 (Create GPU target notification group)
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 27, 2026
…roup, r=jieyouxu

Create GPU target notification group

Creating the notification group for the newly created GPU target (see [mcp#960](https://rust-lang.zulipchat.com/#narrow/channel/233931-t-compiler.2Fmajor-changes/topic/Create.20a.20GPU.20notification.20group.20compiler-team.23960/near/568629680))

I'm following these [steps](rust-lang#133334).

(feel free to suggest a better wording)

r? @jieyouxu
rust-bors bot pushed a commit that referenced this pull request Mar 27, 2026
Rollup of 7 pull requests

Successful merges:

 - #152457 (Pass -pg to linker when using -Zinstrument-mcount)
 - #154031 (Remove divergence check from check_expr_array)
 - #154418 (move many tests out of `ui/unsafe`)
 - #154441 (bootstrap: force a CI LLVM stamp bump)
 - #153662 (Suggest fully qualified path on method name collision)
 - #153675 (simd_add/sub/mul/neg: document overflow behavior)
 - #154430 (Create GPU target notification group)
rust-bors bot pushed a commit that referenced this pull request Mar 27, 2026
Rollup of 6 pull requests

Successful merges:

 - #152457 (Pass -pg to linker when using -Zinstrument-mcount)
 - #154031 (Remove divergence check from check_expr_array)
 - #154418 (move many tests out of `ui/unsafe`)
 - #154441 (bootstrap: force a CI LLVM stamp bump)
 - #153675 (simd_add/sub/mul/neg: document overflow behavior)
 - #154430 (Create GPU target notification group)
@rust-bors rust-bors bot merged commit a16a4c3 into rust-lang:main Mar 27, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 27, 2026
@apiraino apiraino deleted the create-gpu-target-notif-group branch March 27, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants