Make `span_suggestions` always verbose#154605

estebank · 2026-03-30T20:40:28Z

span_suggestions is to provide mutually exclusive suggestions. When it was introduced, we made its behavior be that if a single suggestion is given to it, we present the suggestion inline, otherwise in patch format. Changing this to make all of its uses be verbose, as that is closer in intent of output.

rustbot · 2026-03-30T20:40:35Z

Some changes occurred in tests/ui/sanitizer

cc @rcvalle

rustbot · 2026-03-30T20:40:38Z

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 69 candidates
Random selection from 13 candidates

jieyouxu

Makes sense to me, thanks.

One minor reservation I had while looking at the diffs is when the suggested snippet has placeholders, but then I still liked the verbose outline version over inline help (which is really hard to read IMO).

You can r=me after fixing CI.
@rustbot author

View changes since this review

rustbot · 2026-04-01T01:51:54Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

estebank · 2026-04-01T15:26:40Z

One minor reservation I had while looking at the diffs is when the suggested snippet has placeholders

I saw the same thing and I'm looking at improving the suggestions to be more targeted for cases like those and rely on the "suggestion for full replacement" only as a fallback.

rustbot · 2026-04-02T20:09:10Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

estebank · 2026-04-03T01:13:00Z

@bors r=jieyouxu

rust-bors · 2026-04-03T01:13:03Z

📌 Commit 88d6404 has been approved by jieyouxu

It is now in the queue for this repository.

Rollup of 6 pull requests Successful merges: - #154696 (rustdoc_missing_doc_code_examples: lint on macro_rules macros) - #154698 (Improve workings of the `desc` query modifier and custom query cycle handlers) - #154713 (Stop compiling when we get resolving crate failure) - #154736 (Add a regression test for the duplicated `crate` keyword in path suggestions) - #154739 (ci: update upload-artifact action to v7) - #154741 (Enforce `#![warn(unreachable_pub)]` in compiletest source) Failed merges: - #154605 (Make `span_suggestions` always verbose)

jieyouxu · 2026-04-12T11:15:17Z

(Very conflict-prone)
@bors p=5

jieyouxu · 2026-04-12T11:15:40Z

@bors rollup=iffy (or maybe never)

`span_suggestions` is to provide mutually exclusive suggestions. When it was introduced, we made its behavior be that if a single suggestion is given to it, we present the suggestion inline, otherwise in patch format. Changing this to make all of its uses be verbose, as that is closer in intent of output.

rustbot · 2026-04-15T01:38:29Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

estebank · 2026-04-15T23:45:03Z

@bors r=jieyouxu rollup=never

rust-bors · 2026-04-15T23:45:06Z

📌 Commit b849e10 has been approved by jieyouxu

It is now in the queue for this repository.

Make `span_suggestions` always verbose `span_suggestions` is to provide mutually exclusive suggestions. When it was introduced, we made its behavior be that if a single suggestion is given to it, we present the suggestion inline, otherwise in patch format. Changing this to make all of its uses be verbose, as that is closer in intent of output.

rust-log-analyzer · 2026-04-16T04:11:09Z

The job dist-x86_64-mingw failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

rust-bors · 2026-04-16T04:16:06Z

💔 Test for 7e37fca failed: CI. Failed job:

auto - dist-x86_64-mingw (web logs, enhanced plaintext logs)

jieyouxu · 2026-04-16T08:17:27Z

The hosted runner lost communication with the server. Anything in your workflow that terminates the runner process, starves it for CPU/Memory, or blocks its network access can cause this error.

@bors retry p=1 (conflict-prone)

rust-bors · 2026-04-16T14:51:25Z

☀️ Test successful - CI
Approved by: jieyouxu
Duration: 3h 27m 58s
Pushing 18b439f to main...

github-actions · 2026-04-16T14:54:15Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing e8e4541 (parent) -> 18b439f (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 18b439f84ec0b087283bac3356a1eeac53c60c5e --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-various-1: 58m 48s -> 1h 16m (+29.3%)
x86_64-msvc-ext3: 1h 55m -> 1h 30m (-21.8%)
pr-check-1: 34m 49s -> 27m 45s (-20.3%)
x86_64-gnu-gcc: 1h 10m -> 58m 9s (-17.5%)
dist-x86_64-musl: 2h 6m -> 1h 45m (-16.6%)
x86_64-msvc-ext2: 1h 48m -> 2h 6m (+15.9%)
dist-aarch64-msvc: 1h 37m -> 1h 52m (+15.2%)
i686-msvc-1: 2h 50m -> 3h 14m (+14.2%)
x86_64-rust-for-linux: 55m 31s -> 47m 39s (-14.2%)
aarch64-apple: 2h 33m -> 2h 54m (+14.0%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-04-16T15:42:01Z

Finished benchmarking commit (18b439f): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.3%, 0.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 3.9%, secondary 0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.9%	[3.9%, 3.9%]	1
Regressions ❌ (secondary)	6.0%	[6.0%, 6.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.1%	[-4.1%, -4.1%]	1
All ❌✅ (primary)	3.9%	[3.9%, 3.9%]	1

Cycles

Results (secondary 0.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.7%	[4.7%, 4.7%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.4%	[-3.4%, -3.4%]	1
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 490.756s -> 492.463s (0.35%)
Artifact size: 394.16 MiB -> 394.15 MiB (-0.00%)

rustbot added PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 30, 2026

rustbot assigned jieyouxu Mar 30, 2026

estebank mentioned this pull request Mar 30, 2026

If there are too many suggestions for malformed attribute, do not suggest them #149917

Merged

This comment has been minimized.

Sign in to view

jieyouxu approved these changes Apr 1, 2026

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 1, 2026

estebank force-pushed the attr-suggest branch from c4710fe to 88d6404 Compare April 2, 2026 20:09

rustbot added the T-clippy Relevant to the Clippy team. label Apr 2, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 3, 2026

matthiaskrgr mentioned this pull request Apr 3, 2026

Rollup of 6 pull requests #154746

Merged

rust-bors bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 3, 2026

This comment has been minimized.

Sign in to view

rust-bors bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 3, 2026

estebank force-pushed the attr-suggest branch from 88d6404 to 0be3755 Compare April 10, 2026 18:04

This comment has been minimized.

Sign in to view

estebank force-pushed the attr-suggest branch from 0be3755 to b849e10 Compare April 15, 2026 01:38

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 15, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 16, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 16, 2026

rust-bors bot merged commit 18b439f into rust-lang:main Apr 16, 2026
12 checks passed

rustbot added this to the 1.97.0 milestone Apr 16, 2026

Uh oh!

Conversation

estebank commented Mar 30, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Mar 30, 2026

Uh oh!

rustbot commented Mar 30, 2026

Uh oh!

This comment has been minimized.

jieyouxu left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rustbot commented Apr 1, 2026

Uh oh!

estebank commented Apr 1, 2026

Uh oh!

rustbot commented Apr 2, 2026

Uh oh!

estebank commented Apr 3, 2026

Uh oh!

rust-bors bot commented Apr 3, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jieyouxu commented Apr 12, 2026

Uh oh!

jieyouxu commented Apr 12, 2026

Uh oh!

rustbot commented Apr 15, 2026

Uh oh!

estebank commented Apr 15, 2026

Uh oh!

rust-bors bot commented Apr 15, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Apr 16, 2026

Uh oh!

rust-bors bot commented Apr 16, 2026

Uh oh!

jieyouxu commented Apr 16, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Apr 16, 2026

Uh oh!

Uh oh!

github-actions bot commented Apr 16, 2026

Test differences

Job duration changes

Uh oh!

rust-timer commented Apr 16, 2026

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

estebank commented Mar 30, 2026 •

edited by rustbot

Loading

jieyouxu left a comment •

edited

Loading