Skip to content

add regression test for #146514#154866

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Kcang-gna:add-regression-test-for-#146514
Apr 7, 2026
Merged

add regression test for #146514#154866
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Kcang-gna:add-regression-test-for-#146514

Conversation

@Kcang-gna
Copy link
Copy Markdown
Contributor

@Kcang-gna Kcang-gna commented Apr 6, 2026 •
edited
Loading

Fixes: #146514

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 6, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 6, 2026

r? @JonathanBrouwer

rustbot has assigned @JonathanBrouwer.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 11 candidates

@rustbot

This comment has been minimized.

Sign in to view
@Kcang-gna Kcang-gna closed this Apr 6, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 6, 2026
@Kcang-gna Kcang-gna reopened this Apr 6, 2026
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 6, 2026
@Kcang-gna Kcang-gna force-pushed the add-regression-test-for-#146514 branch 2 times, most recently from a1c28d1 to 61586d0 Compare April 6, 2026 04:59
@reddevilmidzy
Copy link
Copy Markdown
Member

reddevilmidzy commented Apr 6, 2026

NOTE: There is a typo in the PR description. Fixs -> Fixes
cc: https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

@lqd
Copy link
Copy Markdown
Member

lqd commented Apr 6, 2026

Hi, thanks for working on this, could you say more about the test and why you chose this one from the issue? Was it chosen by an LLM? They are known to pick the wrong tests.

@Kcang-gna
Copy link
Copy Markdown
Contributor Author

Kcang-gna commented Apr 7, 2026 •
edited
Loading

Hi, thanks for working on this, could you say more about the test and why you chose this one from the issue? Was it chosen by an LLM? They are known to pick the wrong tests.

I chose this test by the "E-needs-test" label and chose one from top to bottom, with no help from an LLM. The reason I picked the test was that I read this blog don't know what to say about this test. Could you give me some tips?

@Kivooeo
Copy link
Copy Markdown
Member

Kivooeo commented Apr 7, 2026

Hi, thanks for contribution!

For that one I'd suggest to use smaller example from that comment (#146514 (comment))

And also I'm not sure which directory would be better for that one ui/impl-trait or ui/generic-associated-types

@Kcang-gna
Copy link
Copy Markdown
Contributor Author

Kcang-gna commented Apr 7, 2026

Hi, thanks for contribution!

For that one I'd suggest to use smaller example from that comment (#146514 (comment))

And also I'm not sure which directory would be better for that one ui/impl-trait or ui/generic-associated-types

Thanks for the heads-up.

I will use a smaller example. I think ui/impl-trait may be better because I don't see GAT in this example and the impl Trait in associated type appears in an implementation that implements the IntoEmplacable trait for Emp<Arr, F>.

So I will move the file to ui/impl-trait and rename it to associated-impl-trait-type-into-emplacable.rs.

@Kivooeo
Copy link
Copy Markdown
Member

Kivooeo commented Apr 7, 2026

sounds fine to me!

@JonathanBrouwer
Copy link
Copy Markdown
Contributor

JonathanBrouwer commented Apr 7, 2026

r? Kivooeo

@rustbot rustbot assigned Kivooeo and unassigned JonathanBrouwer Apr 7, 2026
@Kcang-gna Kcang-gna force-pushed the add-regression-test-for-#146514 branch from 61586d0 to 7ce2d51 Compare April 7, 2026 08:12
@Kivooeo
Copy link
Copy Markdown
Member

Kivooeo commented Apr 7, 2026

good, thanks!

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 7, 2026

📌 Commit 7ce2d51 has been approved by Kivooeo

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 7, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 7, 2026
@JonathanBrouwer
Rollup merge of rust-lang#154866 - Kcang-gna:add-regression-test-for-r…
fca347a 
…ust-lang#146514, r=Kivooeo

add regression test for rust-lang#146514

Fixes: rust-lang#146514
@JonathanBrouwer JonathanBrouwer mentioned this pull request Apr 7, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 7, 2026
@JonathanBrouwer
Rollup merge of rust-lang#154866 - Kcang-gna:add-regression-test-for-r…
c4665f3 
…ust-lang#146514, r=Kivooeo

add regression test for rust-lang#146514

Fixes: rust-lang#146514
@JonathanBrouwer JonathanBrouwer mentioned this pull request Apr 7, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 7, 2026
@JonathanBrouwer
Rollup merge of rust-lang#154866 - Kcang-gna:add-regression-test-for-r…
6ef5a43 
…ust-lang#146514, r=Kivooeo

add regression test for rust-lang#146514

Fixes: rust-lang#146514
This was referenced Apr 7, 2026
Closed
Merged
rust-bors bot pushed a commit that referenced this pull request Apr 7, 2026
@bors
Auto merge of #154958 - JonathanBrouwer:rollup-PEahluH, r=JonathanBro…
c756124 
…uwer

Rollup of 22 pull requests

Successful merges:

 - #150965 (Fix no results when searching for == in doc)
 - #153999 (Remove `TaggedQueryKey::def_kind`)
 - #154146 (Split out the creation of `Cycle` to a new `process_cycle` function)
 - #154147 (Do not attempt generating DllImport for extern types)
 - #154812 (Update Fira Mono License Information)
 - #154880 (bootstrap: minor improvements to download-rustc)
 - #154886 (Stabilize check-cfg suggestions for symbol)
 - #154889 (Update wasm-component-ld to 0.5.22)
 - #154928 (Fix pin docs)
 - #154942 (delegation: generate more verbose error delegation)
 - #153269 (GCI: During reachability analysis don't try to evaluate the initializer of overly generic free const items)
 - #154506 (Migrate some tests from `tests/ui/issues` to appropriate directories)
 - #154673 (Use a different name for fast try builds)
 - #154761 (coretests: add argument order regression tests for min_by/max_by/minmax_by)
 - #154795 (Add more info about where autodiff can be applied)
 - #154808 (Post-attribute ports cleanup pt. 1)
 - #154825 (constify `Step for NonZero<u*>`)
 - #154837 (library: std: motor: use OS' process::exit in abort_internal)
 - #154866 (add regression test for #146514)
 - #154922 (c-b: Export inverse hyperbolic trigonometric functions)
 - #154931 (delegation(small cleanup): remove not needed PhantomData)
 - #154950 (library: no `cfg(target_arch)` on scalable intrinsics)
@rust-bors rust-bors bot merged commit 2c77e24 into rust-lang:main Apr 7, 2026
11 checks passed
rust-timer added a commit that referenced this pull request Apr 7, 2026
@rust-timer
Unrolled build for #154866
3156cad 
Rollup merge of #154866 - Kcang-gna:add-regression-test-for-#146514, r=Kivooeo

add regression test for #146514

Fixes: #146514
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Apr 8, 2026
@bors
Auto merge of #154958 - JonathanBrouwer:rollup-PEahluH, r=JonathanBro…
0ce6ad6 
…uwer

Rollup of 22 pull requests

Successful merges:

 - rust-lang/rust#150965 (Fix no results when searching for == in doc)
 - rust-lang/rust#153999 (Remove `TaggedQueryKey::def_kind`)
 - rust-lang/rust#154146 (Split out the creation of `Cycle` to a new `process_cycle` function)
 - rust-lang/rust#154147 (Do not attempt generating DllImport for extern types)
 - rust-lang/rust#154812 (Update Fira Mono License Information)
 - rust-lang/rust#154880 (bootstrap: minor improvements to download-rustc)
 - rust-lang/rust#154886 (Stabilize check-cfg suggestions for symbol)
 - rust-lang/rust#154889 (Update wasm-component-ld to 0.5.22)
 - rust-lang/rust#154928 (Fix pin docs)
 - rust-lang/rust#154942 (delegation: generate more verbose error delegation)
 - rust-lang/rust#153269 (GCI: During reachability analysis don't try to evaluate the initializer of overly generic free const items)
 - rust-lang/rust#154506 (Migrate some tests from `tests/ui/issues` to appropriate directories)
 - rust-lang/rust#154673 (Use a different name for fast try builds)
 - rust-lang/rust#154761 (coretests: add argument order regression tests for min_by/max_by/minmax_by)
 - rust-lang/rust#154795 (Add more info about where autodiff can be applied)
 - rust-lang/rust#154808 (Post-attribute ports cleanup pt. 1)
 - rust-lang/rust#154825 (constify `Step for NonZero<u*>`)
 - rust-lang/rust#154837 (library: std: motor: use OS' process::exit in abort_internal)
 - rust-lang/rust#154866 (add regression test for rust-lang/rust#146514)
 - rust-lang/rust#154922 (c-b: Export inverse hyperbolic trigonometric functions)
 - rust-lang/rust#154931 (delegation(small cleanup): remove not needed PhantomData)
 - rust-lang/rust#154950 (library: no `cfg(target_arch)` on scalable intrinsics)
github-actions bot pushed a commit to rust-lang/compiler-builtins that referenced this pull request Apr 9, 2026
@bors
Auto merge of #154958 - JonathanBrouwer:rollup-PEahluH, r=JonathanBro…
43cf9da 
…uwer

Rollup of 22 pull requests

Successful merges:

 - rust-lang/rust#150965 (Fix no results when searching for == in doc)
 - rust-lang/rust#153999 (Remove `TaggedQueryKey::def_kind`)
 - rust-lang/rust#154146 (Split out the creation of `Cycle` to a new `process_cycle` function)
 - rust-lang/rust#154147 (Do not attempt generating DllImport for extern types)
 - rust-lang/rust#154812 (Update Fira Mono License Information)
 - rust-lang/rust#154880 (bootstrap: minor improvements to download-rustc)
 - rust-lang/rust#154886 (Stabilize check-cfg suggestions for symbol)
 - rust-lang/rust#154889 (Update wasm-component-ld to 0.5.22)
 - rust-lang/rust#154928 (Fix pin docs)
 - rust-lang/rust#154942 (delegation: generate more verbose error delegation)
 - rust-lang/rust#153269 (GCI: During reachability analysis don't try to evaluate the initializer of overly generic free const items)
 - rust-lang/rust#154506 (Migrate some tests from `tests/ui/issues` to appropriate directories)
 - rust-lang/rust#154673 (Use a different name for fast try builds)
 - rust-lang/rust#154761 (coretests: add argument order regression tests for min_by/max_by/minmax_by)
 - rust-lang/rust#154795 (Add more info about where autodiff can be applied)
 - rust-lang/rust#154808 (Post-attribute ports cleanup pt. 1)
 - rust-lang/rust#154825 (constify `Step for NonZero<u*>`)
 - rust-lang/rust#154837 (library: std: motor: use OS' process::exit in abort_internal)
 - rust-lang/rust#154866 (add regression test for rust-lang/rust#146514)
 - rust-lang/rust#154922 (c-b: Export inverse hyperbolic trigonometric functions)
 - rust-lang/rust#154931 (delegation(small cleanup): remove not needed PhantomData)
 - rust-lang/rust#154950 (library: no `cfg(target_arch)` on scalable intrinsics)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Kivooeo Kivooeo

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"should not be mangling partially substituted polymorphic instance" with impl_trait_in_assoc_type

6 participants

@Kcang-gna @rustbot @reddevilmidzy @lqd @Kivooeo @JonathanBrouwer