Skip to content

Reduce size of ImportData#155167

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
mejrs:box_directive
Apr 12, 2026
Merged

Reduce size of ImportData#155167
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
mejrs:box_directive

Conversation

@mejrs
Copy link
Copy Markdown
Contributor

@mejrs mejrs commented Apr 11, 2026 •
edited
Loading

Perhaps this will undo the regression caused by #152901

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 11, 2026
@mejrs mejrs mentioned this pull request Apr 11, 2026
Closed
@fmease
Copy link
Copy Markdown
Member

fmease commented Apr 11, 2026

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Apr 11, 2026
@bors
Auto merge of #155167 - mejrs:box_directive, r=<try>
f64c22d 
Reduce size of `ImportData`
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 11, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 11, 2026

☀️ Try build successful (CI)
Build commit: f64c22d (f64c22d98d6f2b7ecba8d8bb08cb8be885331545, parent: bf4fbfb7a18d74e7cd8eef93af7329c58fbb5344)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Copy Markdown
Collaborator

rust-timer commented Apr 11, 2026

Finished benchmarking commit (f64c22d): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.4% [-0.4%, -0.4%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.4% [-0.4%, -0.4%] 1

Max RSS (memory usage)

Results (primary -1.1%, secondary -0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 5.7% [5.7%, 5.7%] 1
Improvements ✅
(primary)		 -1.1% [-1.1%, -1.1%] 1
Improvements ✅
(secondary)		 -6.2% [-6.2%, -6.2%] 1
All ❌✅ (primary) -1.1% [-1.1%, -1.1%] 1

Cycles

Results (primary -8.2%, secondary -2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -8.2% [-8.8%, -7.5%] 2
Improvements ✅
(secondary)		 -2.5% [-3.1%, -1.7%] 3
All ❌✅ (primary) -8.2% [-8.8%, -7.5%] 2

Binary size

Results (primary -0.0%, secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.0% [-0.0%, -0.0%] 4
Improvements ✅
(secondary)		 -0.0% [-0.1%, -0.0%] 13
All ❌✅ (primary) -0.0% [-0.0%, -0.0%] 4

Bootstrap: 490.796s -> 491.012s (0.04%)
Artifact size: 394.14 MiB -> 394.09 MiB (-0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 11, 2026
@mejrs
Copy link
Copy Markdown
Contributor Author

mejrs commented Apr 11, 2026

Thanks for starting the perf run. That looks like most of what was lost.

FWIW I've opened #155174 which (unlike #155155) never checks features on the happy path. I don't think it is measurable but I guess we could do a perf run on that as well if you wish.

@mejrs mejrs marked this pull request as ready for review April 11, 2026 23:56
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 11, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 11, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 11, 2026

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 11 candidates

@Kivooeo
Copy link
Copy Markdown
Member

Kivooeo commented Apr 12, 2026

r? me @bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 12, 2026

📌 Commit c4e4156 has been approved by Kivooeo

It is now in the queue for this repository.

@rust-bors rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 12, 2026
@rust-bors rust-bors bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 12, 2026
@jhpratt jhpratt mentioned this pull request Apr 12, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Apr 12, 2026
@bors
Auto merge of #155175 - jhpratt:rollup-jQuvnVx, r=jhpratt
6ad4d1b 
Rollup of 7 pull requests

Successful merges:

 - #155084 (Initial functions to start on transmute v2)
 - #155126 (add `cfg(target_object_format = "...")`)
 - #155165 (Portable SIMD subtree update)
 - #153871 (fix spurious test failure in `metadata_access_times`)
 - #155150 (replace <name> @ ty::AliasTy matches with just using args: <name>_args)
 - #155159 (Fix min-specialization ICE from ignored region resolution failure)
 - #155167 (Reduce size of `ImportData`)
@rust-bors rust-bors bot merged commit 040b6db into rust-lang:main Apr 12, 2026
12 checks passed
rust-timer added a commit that referenced this pull request Apr 12, 2026
@rust-timer
Unrolled build for #155167
74a6338 
Rollup merge of #155167 - mejrs:box_directive, r=Kivooeo

Reduce size of `ImportData`

Perhaps this will undo the regression caused by #152901
@rustbot rustbot added this to the 1.97.0 milestone Apr 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Kivooeo Kivooeo

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

6 participants

@mejrs @fmease @rust-timer @rustbot @Kivooeo @jackh726