Check diagnostic output in incremental cpass and rpass revisions#155228
Open
Zalathar wants to merge 3 commits intorust-lang:mainfrom
Open
Check diagnostic output in incremental cpass and rpass revisions#155228Zalathar wants to merge 3 commits intorust-lang:mainfrom
cpass and rpass revisions#155228Zalathar wants to merge 3 commits intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
rustbot
added
A-compiletest
Collaborator
|
r? @clubby789 rustbot has assigned @clubby789. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
r? me |
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Ugh, a Linux-only test emitting warnings.
EDIT: The warnings appear to be GCC-only, so I applied an |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
@bors try jobs=x86_64-gnu |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 13, 2026
Check diagnostic output in incremental `cpass` and `rpass` revisions try-job: x86_64-gnu
This avoids having to add several unhelpful annotations when enabling diagnostic checks for `cpass` and `rpass` revisions.
This allows warnings to be annotated, and verifies that no unexpected warnings occur.
Zalathar
force-pushed
the
incr-test-diag
branch
from
e8fae41 to
316fcbd
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows compiler warnings to be annotated in
cpassandrpassrevisions, and verifies that no unexpected warnings occur.My underlying motivation is that I want to be able to reduce or eliminate the confusing combination of
cfailrevisions with//@ build-passdirectives, and replace them with a more straightforwardcpassrevision that also checks diagnostic output. That migration is not part of this PR.