Handle supertrait calls in default methods#4537
Closed
catamorphism wants to merge 2 commits intorust-lang:incomingfrom
Closed
Handle supertrait calls in default methods#4537catamorphism wants to merge 2 commits intorust-lang:incomingfrom
catamorphism wants to merge 2 commits intorust-lang:incomingfrom
Conversation
Contributor
Author
|
n.b. This only handles supertrait method calls on |
Add a new method_super origin for supertrait methods. Also make coherence create a table that maps pairs of trait IDs and self types to impl IDs, so that it's possible to check a supertrait method knowing only its index in its trait's methods (without knowing all supertraits for a given trait). As per rust-lang#3979
Contributor
|
r+ from a style and direction perspective (and it looks great); unfortunately it also looks Serious enough that I'm not real comfortable pretending to be able to judge semantic correctness. Maybe get someone who knows the numerous related invariants to double-check? |
Contributor
Author
|
@nikomatsakis - Can you double-check? |
Contributor
|
@catamorphism ok will take a look today |
Contributor
Author
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Sep 3, 2025
Automatic Rustup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @graydon Add a new method_super origin for supertrait methods. Also make
coherence create a table that maps pairs of trait IDs and self types
to impl IDs, so that it's possible to check a supertrait method
knowing only its index in its trait's methods (without knowing all
supertraits for a given trait).
As per #3979