Add AbiSet and integrate it into the AST.#5421
Closed
nikomatsakis wants to merge 3 commits intorust-lang:incomingfrom
Closed
Add AbiSet and integrate it into the AST.#5421nikomatsakis wants to merge 3 commits intorust-lang:incomingfrom
nikomatsakis wants to merge 3 commits intorust-lang:incomingfrom
Conversation
I believe this patch incorporates all expected syntax changes from extern function reform (rust-lang#3678). You can now write things like: extern "<abi>" fn foo(s: S) -> T { ... } extern "<abi>" mod { ... } extern "<abi>" fn(S) -> T The ABI for foreign functions is taken from this syntax (rather than from an annotation). We support the full ABI specification I described on the mailing list. The correct ABI is chosen based on the target architecture. Calls by pointer to C functions are not yet supported, and the Rust type of crust fns is still *u8.
Closed
Contributor
|
@nikomatsakis I rebased this into #5631. I think there's probably not much here I could mess up, but you might want to peek at it. |
bors
added a commit
that referenced
this pull request
Mar 30, 2013
oli-obk
pushed a commit
to oli-obk/rust
that referenced
this pull request
May 2, 2020
…lip1995 CONTRIBUTING.md: fix broken triage link Fixes rust-lang#5421
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this patch incorporates all expected syntax changes from extern
function reform (#3678). You can now write things like:
The ABI for foreign functions is taken from this syntax (rather than from an
annotation). We support the full ABI specification I described on the mailing
list. The correct ABI is chosen based on the target architecture.
Calls by pointer to C functions are not yet supported, and the Rust type of
crust fns is still *u8.
r? @brson