Fixes #63962. Hint about missing tuple parentheses in patterns#64619
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 22, 2019
sam09:fix-63962
Merged
Fixes #63962. Hint about missing tuple parentheses in patterns#64619bors merged 1 commit intorust-lang:masterfrom sam09:fix-63962
bors merged 1 commit intorust-lang:masterfrom
sam09:fix-63962
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
|
r? @Centril |
Centril
suggested changes
Sep 19, 2019
Contributor
Centril
left a comment
Centril
left a comment
There was a problem hiding this comment.
Thanks! Here are some ways to improve things.
Centril
added
S-waiting-on-author
Contributor
Author
This comment has been minimized.
This comment has been minimized.
estebank
reviewed
Sep 20, 2019
estebank
approved these changes
Sep 20, 2019
estebank
reviewed
Sep 20, 2019
estebank
reviewed
Sep 20, 2019
Contributor
|
r=me once green |
Contributor
Author
|
r? @estebank |
Contributor
|
Thanks! @bors r=Centril,estebank |
Collaborator
|
📌 Commit 66298d97a4f11b78ccbead79b6fd00be4b1f2156 has been approved by |
bors
added
S-waiting-on-bors
Contributor
|
@sam09 Can you please fixup the second commit into the first? |
Contributor
Author
Done |
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit a2a57bc has been approved by |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Sep 21, 2019
Fixes rust-lang#63962. Hint about missing tuple parentheses in patterns
bors
added a commit
that referenced
this pull request
Sep 22, 2019
Rollup of 9 pull requests Successful merges: - #63907 (Add explanation to type mismatch involving type params and assoc types) - #64615 (rustbuild: Turn down compression on exe installers) - #64617 (rustbuild: Turn down compression on msi installers) - #64618 (rustbuild: Improve output of `dist` step) - #64619 (Fixes #63962. Hint about missing tuple parentheses in patterns) - #64634 (Update to LLVM 9.0.0) - #64635 (Allow using fn pointers in const fn with unleash miri) - #64660 (unify errors for tuple/struct variants) - #64664 (fully remove AstBuilder) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.