Merged
Conversation
in xml_xpath_context.c, both functions `evaluate` and `Nokogiri_marshal_xpath_funcall_and_return_values` had code to convert xpath objects to Ruby objects. `Nokogiri_marshal_xpath_funcall_and_return_values` had a memory leak while `evaluate` did not. I've extracted this logic to a single method, and called it from both places, thereby eliminating the memory leak along with DRYing things up. Also, I've added a bit of test coverage to some of the marshalling.
- namespaces array was not being freed - argument type errors led to output buffer not being freed Also note that I cleaned up this function a bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Playing with ruby_memcheck led to finding a few easy-to-fix memory leaks.
Document#canonicalizeleaked the namespaces arrayDocument#canonicalizeleaked the output buffer when argument type errors were raisedHave you included adequate test coverage?
#2344 is a parallel effort to automate the leak checking that I ran on the existing test suite to find these.