NAS-121621 / 23.10 / remove onedrivesdk (deprecated a long time ago)

[yocalebo]

This module hasn't seen a commit since 2016 so it's dead and it does not work with python3.11 (ships in Cobia). There doesn't seem to be a decent alternative either so we'll drop this for now and revisit if we find another solution.

[bugclerk]

Jira URL: https://ixsystems.atlassian.net/browse/NAS-121621

[imkiva]

Hi all. I just made onedrivesdk compatible with Python 3.11. You can find the repo with my fixes here: https://github.com/imkiva/onedrive-sdk-python and a corresponding Pull Request has been made to the upstream: OneDrive/onedrive-sdk-python#206

I have tested it locally and found it still works just like before. Is it possible to add OneDrive CloudSync back?

[yocalebo]

Hi all. I just made onedrivesdk compatible with Python 3.11. You can find the repo with my fixes here: https://github.com/imkiva/onedrive-sdk-python and a corresponding Pull Request has been made to the upstream: OneDrive/onedrive-sdk-python#206

I have tested it locally and found it still works just like before. Is it possible to add OneDrive CloudSync back?

Hi @imkiva, great job on fixing this! However, we've got no plans on bringing this back. Unless your PR is merged upstream and a new version is published on pypi, I don't see this provider being added again. The last PR that was merged upstream was 7 years ago. I don't expect yours to be merged, unfortunately. Furthermore, this adds support for 3.11 but 3.12 is already released and we will try and keep up to date with the Python versions. Even if we were to bring this back, I suspect new versions of Python will render this library unusable and so we'll be forced, yet again, to remove it.

[ljg-dev]

Hi all. I just made onedrivesdk compatible with Python 3.11. You can find the repo with my fixes here: https://github.com/imkiva/onedrive-sdk-python and a corresponding Pull Request has been made to the upstream: OneDrive/onedrive-sdk-python#206
I have tested it locally and found it still works just like before. Is it possible to add OneDrive CloudSync back?

Hi @imkiva, great job on fixing this! However, we've got no plans on bringing this back. Unless your PR is merged upstream and a new version is published on pypi, I don't see this provider being added again. The last PR that was merged upstream was 7 years ago. I don't expect yours to be merged, unfortunately. Furthermore, this adds support for 3.11 but 3.12 is already released and we will try and keep up to date with the Python versions. Even if we were to bring this back, I suspect new versions of Python will render this library unusable and so we'll be forced, yet again, to remove it.

And what would you consider acceptable to bring it back if a whole rewrite of the library isn't enough? I don't mean to be disrespectful but if the last time it was updated was 2016, and it worked until now, I don't see any reason why it should stop working in the near future, Python doesn't change that much in short time periods., even if you keep it up to date.

I understand that maybe that feature is not important for TrueNas, but from a user standpoint, it doesn't seem to be right to just remove support for one of the major cloud storage providers there is, without giving us any alternative. How can we be sure that you won't remove support for google drive or S3 tomorrow?