Fix issue #11615 handle unicode encode error when print stack trace #12758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This PR fixed issue #11615 |
MrMino
reviewed
Apr 4, 2021
| try: | ||
| print(val) | ||
| except UnicodeEncodeError: | ||
| print(val.encode("utf-8", "backslashreplace").decode()) |
Member
There was a problem hiding this comment.
What are the benefits of having try...except here rather than just print(val.encode(...).decode())?
Member
There was a problem hiding this comment.
I believe this is question of efficiency. In most case print() will work, so there is no need to do the expensive encode(), then .decode() dance, that would in the end often be no-op.
Member
|
I think that it's harmless enough that we can get that in. |
meeseeksmachine
pushed a commit
to meeseeksmachine/ipython
that referenced
this pull request
Apr 14, 2021
…ode error when print stack trace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.