Skip to content

Conversation

@MrMino
Copy link
Member

@MrMino MrMino commented May 6, 2021

Fixes #12946

@MrMino
Copy link
Member Author

MrMino commented May 6, 2021

Am I reading this correctly? Has darker flipped over on this code?

Run darker -r 60625f241f298b5039cb2debc365db38aa7bb522 --check --diff . || (
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.8.10/x64/bin/darker", line 5, in <module>
    from darker.__main__ import main
  File "/opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/site-packages/darker/__main__.py", line 16, in <module>
    from darker.import_sorting import apply_isort, isort
  File "/opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/site-packages/darker/import_sorting.py", line 22, in <module>
    isort_code = getattr(isort, "code")
AttributeError: 'NoneType' object has no attribute 'code'

@ivanov
Copy link
Member

ivanov commented May 7, 2021

The believe that the darker error is caused by isort not being installed

@ivanov
Copy link
Member

ivanov commented May 7, 2021

The believe that the darker error is caused by isort not being installed

now fixed on master, so you won't get any trouble from darker once you rebase.
Happy hacking! :bowtie:

@Carreau Carreau added this to the 7.24 milestone May 11, 2021
@Carreau Carreau merged commit 9e003eb into ipython:master May 11, 2021
meeseeksmachine pushed a commit to meeseeksmachine/ipython that referenced this pull request May 11, 2021
Carreau added a commit that referenced this pull request May 11, 2021
…952-on-7.x

Backport PR #12952 on branch 7.x (Ensure %recall does not show error after argument eval)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

%recall mistakenly prints "Couldn't evaluate or find in history"

3 participants