Have a dual for `--no-inline` that will cause a function to be always inlined (modulo recursive inlining)

[mkustermann]

wasm-opt has the --no-inline=<function-name-glob-pattern> argument which one can use to disallow inlining certain functions.

It would be great if we have a similar --prefer-inline=<function-name-glob-pattern> flag that tells binaryen to always inline certain functions irrespective of other flags (e.g. -Os may prevent it from being inlined as it would make size bigger, but do it nonetheless). Basically it would cause force inlining of those methods except in cases that would lead to issues (e.g. infinite recursive inlining)

From looking at wasm-opt --help --verbose it doesn't seem like there's such a flag atm.

[kripken]

We have an --inline-main pass that inlines __original_main into main (important for LLVM output). We could extend that to get a list of functions to force-inline. I guess avoiding recursion would be the nontrivial part, as you say.

[kripken]

Talking offline, the best path forward here is to add code annotations, which are now well-supported in binaryen, and easy for tools to emit. That is, inline/etc. should be added alongside the intrinsics here: https://github.com/WebAssembly/binaryen/wiki/Optimizer-Cookbook#intrinsics

[mkustermann]

Thank you very much, @kripken !