Require implementations support exactly the inclusive range [3000, 768000] for sample rate - #2657
Merged
Merged
Conversation
Contributor
Author
|
WPT update is in progress here: https://crrev.com/c/7204605 |
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Dec 8, 2025
The specification is being updated to put different requirements on the sample rate in WebAudio. Update the WPT to reflect this. See WebAudio/web-audio-api#2657 Change-Id: Ic99a306da2cf625b52168c4143c0a3320aef1087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7204605 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1555679}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 8, 2025
The specification is being updated to put different requirements on the sample rate in WebAudio. Update the WPT to reflect this. See WebAudio/web-audio-api#2657 Change-Id: Ic99a306da2cf625b52168c4143c0a3320aef1087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7204605 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1555679}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 8, 2025
The specification is being updated to put different requirements on the sample rate in WebAudio. Update the WPT to reflect this. See WebAudio/web-audio-api#2657 Change-Id: Ic99a306da2cf625b52168c4143c0a3320aef1087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7204605 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1555679}
hoch
approved these changes
Dec 19, 2025
lando-worker Bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Jan 21, 2026
…options.html, a=testonly SKIP_BMO_CHECK The specification is being updated to put different requirements on the sample rate in WebAudio. Update the WPT to reflect this. See WebAudio/web-audio-api#2657 Change-Id: Ic99a306da2cf625b52168c4143c0a3320aef1087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7204605 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1555679} wpt-commit: 0bf56d544f158e222ed3ae08aacd11c1df3ab94f wpt-pr: 56569
MukundaKatta
added a commit
to MukundaKatta/web-audio-api-rs
that referenced
this pull request
Apr 15, 2026
The Web Audio API specification mandates that implementations support every sample rate in the inclusive range [3000, 768000]. Previously `assert_valid_sample_rate` rejected values outside [2000, 384000], which both rejected spec-valid rates like 480000 and 768000 and accepted rates below the spec's 3000 Hz minimum. Align the bounds with the spec and add boundary regression tests. See WebAudio/web-audio-api#2657. Closes orottier#563.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2649.
As decided at TPAC 2025, expand the required sample rate range from 3000 to 768000 Hz inclusive, and require that implementations reject rates outside this range.
Preview | Diff