Skip to content

Restore the v4 repository foundation - #2399

Merged
monadoid merged 2 commits into
v4-spikefrom
v4-production-foundation
Jul 25, 2026
Merged

monadoid merged 2 commits into
v4-spikefrom
v4-production-foundation

Conversation

@monadoid

@monadoid monadoid commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

So the v4-spike branch that this PR would merge into is the code from the v4-spike repo. On that branch, I have done only two things exactly:

  1. Removed all of the existing v3 code, leaving an empty repository.
  2. Copied in the v4 spike exactly as it existed in the original spike repository.

This makes the transition easy to follow. The end goal will be that this v4-spike repo gets merged into main on launch. To do that, we now need to add back in all of the parts of v3 we want, as well as continue to improve v4, in atomic PRs.

This PR simply restores the top-level files from v3 that we want to keep directly in v4 (with no changes):

  • the license
  • CODEOWNERS
  • the pull request template
  • the bug report and feature request templates
  • the Cubic configuration and rules

In this stack of PRs, we'll start adding back in the v3 code we want, piece by piece.

@changeset-bot

changeset-bot Bot commented Jul 24, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 29e7c4d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@monadoid monadoid changed the title restore repository foundation Restore the v4 repository foundation Jul 24, 2026
@monadoid
monadoid force-pushed the v4-production-foundation branch from 4d4d3bf to 9f66fd9 Compare July 24, 2026 02:00
@monadoid
monadoid marked this pull request as ready for review July 24, 2026 18:22

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 8 files

Confidence score: 5/5

  • In .cubic/docs-style-guide.md, the SDK-page guidance points to packages/docs/scripts/sync-sdk-docs.js, which doesn’t exist yet, so generated findings may be misrouted or dropped and create review noise rather than product regressions — update the reference to the real generator once added, or keep the target path generic for now.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".cubic/docs-style-guide.md">

<violation number="1" location=".cubic/docs-style-guide.md:7">
P3: Generated SDK-page findings cannot be routed to the named path because `packages/docs/scripts/sync-sdk-docs.js` does not exist. Use the actual generator when it is added, or describe the target generically so this rule remains actionable.</violation>
</file>
Architecture diagram
sequenceDiagram
    participant PR as Contributor
    participant GH as GitHub
    participant Cubic as Cubic CI
    participant Repo as v4-spike Repository

    Note over PR,Repo: PR restores top-level v3 foundation files into v4-spike

    PR->>GH: Opens PR with 8 restored files
    GH->>Repo: Checks CODEOWNERS (/.github/CODEOWNERS)
    alt File match: /packages/docs/**
        Repo-->>GH: Route review to @browserbase/gtm
    end

    GH->>Cubic: Triggers Cubic review
    alt File path: packages/docs/**
        Cubic->>Cubic: Loads custom rules from cubic.yaml
        Cubic->>Cubic: Applies docs-style-guide.md rules
        Note over Cubic: Blocking rules: prose style, voice,<br/>casing, Oxford comma, etc.
        Cubic-->>GH: Review comments on new/modified docs prose
    end

    Repo-->>GH: Confirms file additions:
    Note over Repo: LICENSE (MIT)<br/>CHANGELOG.md (v3 history)<br/>CODEOWNERS<br/>PR template<br/>Bug/Feature templates<br/>cubic.yaml + style guide

    GH->>PR: Updates with CI status and review assignments
Loading

Reply with feedback, questions, or to request a fix.

Re-trigger cubic


Apply these rules only to public-facing prose under `packages/docs/**`, including frontmatter descriptions, headings, navigation labels, paragraphs, tables, callouts, and authored code comments.

Do not apply prose rules to code identifiers, executable code, URLs, copied prompts, sample task strings, configuration examples, or logs. Do not request direct edits to generated SDK pages under `packages/docs/v3/sdk/`; report source-content problems against the owning SDK repository or `packages/docs/scripts/sync-sdk-docs.js`.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: Generated SDK-page findings cannot be routed to the named path because packages/docs/scripts/sync-sdk-docs.js does not exist. Use the actual generator when it is added, or describe the target generically so this rule remains actionable.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .cubic/docs-style-guide.md, line 7:

<comment>Generated SDK-page findings cannot be routed to the named path because `packages/docs/scripts/sync-sdk-docs.js` does not exist. Use the actual generator when it is added, or describe the target generically so this rule remains actionable.</comment>

<file context>
@@ -0,0 +1,64 @@
+
+Apply these rules only to public-facing prose under `packages/docs/**`, including frontmatter descriptions, headings, navigation labels, paragraphs, tables, callouts, and authored code comments.
+
+Do not apply prose rules to code identifiers, executable code, URLs, copied prompts, sample task strings, configuration examples, or logs. Do not request direct edits to generated SDK pages under `packages/docs/v3/sdk/`; report source-content problems against the owning SDK repository or `packages/docs/scripts/sync-sdk-docs.js`.
+
+## Scope boundary
</file context>
Suggested change
Do not apply prose rules to code identifiers, executable code, URLs, copied prompts, sample task strings, configuration examples, or logs. Do not request direct edits to generated SDK pages under `packages/docs/v3/sdk/`; report source-content problems against the owning SDK repository or `packages/docs/scripts/sync-sdk-docs.js`.
Do not apply prose rules to code identifiers, executable code, URLs, copied prompts, sample task strings, configuration examples, or logs. Do not request direct edits to generated SDK pages; report source-content problems against the owning SDK repository or generator.

@monadoid
monadoid force-pushed the v4-production-foundation branch from 1b49c56 to 29e7c4d Compare July 25, 2026 00:03
@monadoid
monadoid merged commit 6877f42 into v4-spike Jul 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants