Skip to content

implement TLSSocket and connect from node:tls - #3594

Merged
anonrig merged 1 commit into
mainfrom
yagiz/introduce-tls
Mar 6, 2025
Merged

anonrig merged 1 commit into
mainfrom
yagiz/introduce-tls

Conversation

@anonrig

@anonrig anonrig commented Feb 23, 2025

Copy link
Copy Markdown
Contributor

Adds node:tls module as well as _tls_wrap. Includes the following methods/classes:

  1. TLSSocket
  2. connect()

@anonrig
anonrig force-pushed the yagiz/introduce-tls branch 2 times, most recently from 1fb6373 to e77192f Compare February 24, 2025 01:28
@github-actions

github-actions Bot commented Feb 24, 2025

Copy link
Copy Markdown

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

@cloudflare cloudflare deleted a comment from github-actions Bot Feb 24, 2025
@danlapid

Copy link
Copy Markdown
Collaborator

Nice!
Glad to see this progressing!

@anonrig
anonrig force-pushed the yagiz/introduce-tls branch 8 times, most recently from 7968547 to a8848ab Compare February 26, 2025 16:11
Comment thread src/workerd/api/node/tests/tls-nodejs-test.js Fixed
@anonrig
anonrig force-pushed the yagiz/introduce-tls branch 11 times, most recently from 5c957db to 57490be Compare February 28, 2025 22:50
@anonrig
anonrig marked this pull request as ready for review February 28, 2025 22:53
@anonrig
anonrig requested review from a team as code owners February 28, 2025 22:53
@anonrig
anonrig requested review from a team and erikcorry February 28, 2025 22:53
Comment thread src/workerd/api/node/tests/tls-nodejs-test.js
Comment thread src/workerd/api/node/tests/tls-nodejs-tcp-server.js Outdated
Comment thread src/node/internal/internal_tls_wrap.ts Outdated
Comment thread src/node/internal/internal_tls_wrap.ts
Comment thread src/node/internal/internal_tls_wrap.ts Outdated
Comment thread src/node/internal/internal_tls_wrap.ts Outdated
Comment thread src/node/internal/internal_tls_wrap.ts
Comment thread src/node/internal/internal_tls_wrap.ts
Comment thread src/node/internal/internal_tls_wrap.ts
Comment thread src/node/internal/internal_tls_wrap.ts
Comment thread src/node/internal/internal_tls_wrap.ts Outdated
Comment thread src/node/internal/internal_tls_wrap.ts
Comment thread src/node/internal/internal_net.ts
@anonrig
anonrig force-pushed the yagiz/introduce-tls branch from 4864e5c to 57ae248 Compare March 6, 2025 20:37
@anonrig
anonrig enabled auto-merge (rebase) March 6, 2025 20:46
@anonrig
anonrig merged commit 4e753b6 into main Mar 6, 2025
@anonrig
anonrig deleted the yagiz/introduce-tls branch March 6, 2025 21:22
@anonrig

anonrig commented Mar 6, 2025

Copy link
Copy Markdown
Contributor Author

cc @vicb @petebacondarwin once we have an EW release, we should update unenv to not polyfill these...

cc @irvinebroque @mikenomitch it might be good to include this in a changelog entry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants