fix: blend node and blink code generation policy when both are loaded - #36567
Merged
Merged
Conversation
nornagon
added
semver/patch
MarshallOfSound
approved these changes
Dec 8, 2022
deepak1556
reviewed
Dec 8, 2022
| // If we're running with contextIsolation enabled in the renderer process, | ||
| // fall back to Blink's logic. | ||
| if (node::Environment::GetCurrent(context) == nullptr) { | ||
| if (gin_helper::Locker::IsBrowserProcess()) { |
Member
There was a problem hiding this comment.
Which scenario we support today might enter this block ? Don't we always have a node environment in the browser process ?
Contributor
Author
There was a problem hiding this comment.
None, hence the NOTREACHED below
Member
There was a problem hiding this comment.
Do we even need the NOTREACHED in that case ? My understanding is that NOTREACHED is useful to abort when there is no default action for switch statements or when an method is not implemented.
Contributor
Author
There was a problem hiding this comment.
I guess this could just be a CHECK :)
deepak1556
approved these changes
Dec 8, 2022
|
Release Notes Persisted
|
trop Bot
added a commit
that referenced
this pull request
Dec 14, 2022
…#36567) Co-authored-by: Jeremy Rose <jeremya@chromium.org>
trop Bot
added a commit
that referenced
this pull request
Dec 14, 2022
…#36567) Co-authored-by: Jeremy Rose <jeremya@chromium.org>
Contributor
|
I have automatically backported this PR to "23-x-y", please check out #36667 |
Contributor
|
I have automatically backported this PR to "22-x-y", please check out #36668 |
trop
Bot
added
in-flight/23-x-y
merged/23-x-y
codebytere
pushed a commit
that referenced
this pull request
Jan 2, 2023
…#36668) * fix: blend node and blink code generation policy when both are loaded (#36567) Co-authored-by: Jeremy Rose <jeremya@chromium.org> * Update .patches * fix patches Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Jeremy Rose <jeremya@chromium.org> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
trop
Bot
added
merged/22-x-y
3 tasks
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This fixes a crash in some situations when sandbox: false.
Checklist
npm testpassesRelease Notes
Notes: Fixed a crash that could occur when running eval in inline scripts in unsandboxed renderer processes.