Update hypersync client field selection and bindings - #117
Conversation
| transaction_fields: | ||
| - hash | ||
| - transaction_index | ||
| - transactionIndex |
There was a problem hiding this comment.
Didn't we decide to change it to index? Or is it a part of another PR?
There was a problem hiding this comment.
Have a look at the thread on this closed PR enviodev/hypersync-client-node#24
It was decided that it's best to keep it transactionIndex
| field_selection: | ||
| transaction_fields: |
There was a problem hiding this comment.
Should they be camel case as well?
There was a problem hiding this comment.
Yes will update thanks 👍🏼
There was a problem hiding this comment.
Oh actually sorry I misread this comment. I think the answer is no since the rest of human config uses snake case for parameters.
| nonce?: int, //nullable | ||
| nonce?: bigint, |
There was a problem hiding this comment.
Maybe keep the nullable comment? And if it's returned as null won't it break things?
There was a problem hiding this comment.
With the updated client it's no longer nullable. I'm copying directly the types generated from the Napi framework.
2 participants
camelCaseinstead ofsnake_caseto match the fields that get returned from requestPascalCasefor field selection for new enum type