Add unit tests for fetchstate - #146
Merged
Merged
Conversation
DZakh
approved these changes
Aug 26, 2024
DZakh
left a comment
DZakh
left a comment
Member
There was a problem hiding this comment.
I didn't review the tests in detail, after a quick glance they look good. That's definitely good to have tests :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These new unit tests add about 77% coverage for FetchState
I managed to catch 2 bugs with them. One a problematic bug for rollbacks and one being non critical for calculating sizes of partitions.
There's still more to test but it's time consuming and I think this is already a good addition.