feat: add citrea and alphabetical ordering - #173
Conversation
There was a problem hiding this comment.
I did the ordering manually as both supermaven & chatgpt where changing the logic. Was tedious 😅
There was a problem hiding this comment.
Bummer! Thanks, I like the alphabetical ordering. Maybe it's best to add a quick test to ensure people are adding these values in alphabetical order 😅
| ArbitrumNova = 42170, | ||
|
|
||
| #[subenum(HypersyncNetwork, NetworkWithExplorer, GraphNetwork)] | ||
| Goerli = 5, |
There was a problem hiding this comment.
Goerli didn't make sense to be second, I get having eth 1st as its popular but I don't think we should be opinionated on network popularity. Sensible to be alphabetical to me
| #[subenum(HypersyncNetwork)] | ||
| // blocksout: https://explorer.devnet.citrea.xyz/ | ||
| CitreaDevnet = 62298, |
There was a problem hiding this comment.
This is the only addition. It would be nice to have in a release for my workshop tomorrow but I can also work around it for now.
| // Still syncing | ||
| // #[subenum(HypersyncNetwork)] | ||
| // KakarotSepolia = 1802203764, |
There was a problem hiding this comment.
This is not synced so commented out
| | Network::ArbitrumSepolia => 0, | ||
| | Network::ArbitrumOne | ||
| | Network::ArbitrumSepolia | ||
| | Network::CitreaDevnet |
There was a problem hiding this comment.
Citrea is reorg resistant 👍
| @@ -269,81 +346,81 @@ impl Network { | |||
| pub fn get_confirmed_block_threshold(&self) -> i32 { | |||
There was a problem hiding this comment.
this ordering is just for readability
|
Looking at the test now |
|
Can we add this to enforce people adding in alphabetical order in future? #174 |
JonoPrest
left a comment
JonoPrest
left a comment
There was a problem hiding this comment.
Thanks Den, sorry about the issues with the help doc 🙏🏼
|
Should get the test passing: #175 |
3 participants
No description provided.