V1 - Do not rely on api keys for contract verifycation but keep them as a fallback - #37
Conversation
JasoonS
changed the title
|
Here's the diff of the codegen output.🙌🧠🦜 |
JasoonS
changed the title
|
|
||
| // Selecting the api_key to be used based on the index | ||
| let api_key = api_keys[api_key_index]; | ||
| let api_key: Option<String> = if rate_limit_retry_count == 0 { |
There was a problem hiding this comment.
I'm wondering if there is a case where the rate_limit_retry_count can be more than 0 but this is used again. For example when trying to import multiple contracts. Hence first contract won't use api keys and then subsequent requests will?
There was a problem hiding this comment.
It resets to zero each time from what I saw.
036a88a to
4a86aa3
Compare
|
Ok, I think this is ready 💪 Completely removed API tokens. Tried out a few ways to allow users to add their own API tokens if the API blocks them. In the above image I had to artificially cause the retrieval of the contract to fail (I couldn't get it to fail without forcing it to fail). So I'm confident that it will be an unlikely edge case that a user will need to provide their own API tokens. |
3 participants
Read comments here: #36