Handle HyperSync logs query errors - #502
Merged
Merged
Conversation
JonoPrest
reviewed
Apr 7, 2025
Comment on lines
+395
to
+401
| // Starting from the 11th failure (retry=10) | ||
| // include fallback sources for switch | ||
| // (previously it would consider only sync sources or the initial one) | ||
| // This is a little bit tricky to find the right number, | ||
| // because meaning between RPC and HyperSync is different for the error | ||
| // but since Fallback was initially designed to be used only for height check | ||
| // just keep the value high |
Collaborator
There was a problem hiding this comment.
We should probably note this in the config description. Since a user might want to have an expensive rpc for the head and not use it for the sync.
Member
Author
There was a problem hiding this comment.
Hm, probably need to add the logic to disable fallbacks for historical sync
JonoPrest
reviewed
Apr 7, 2025
| | WrongInstance => | ||
| let backoffMillis = switch retry { | ||
| | 0 => 100 | ||
| | _ => 500 * retry |
Collaborator
There was a problem hiding this comment.
Maybe this should have ceiling? A multiplicative of 500 is huge if somehow this happens multiple times.
Member
Author
There was a problem hiding this comment.
There's a global ceiling of 60 seconds
JonoPrest
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't crash the indexer on HyperSync logs request query error. Infinitely retry with the support of a fallback data source.