Fix sei-apis rpc error handling - #654
Merged
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughA new regular expression was introduced in the internal logic of the Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant RpcSource
Caller->>RpcSource: getSuggestedBlockIntervalFromExn(error)
alt Matches blockpiRangeRegExp
RpcSource-->>Caller: Return parsed interval
else Matches maxAllowedBlocksRegExp
RpcSource-->>Caller: Return max allowed blocks interval
else Matches baseRangeRegExp
RpcSource-->>Caller: Return 2000
else Matches blastPaidRegExp
RpcSource-->>Caller: Return parsed interval
else
RpcSource-->>Caller: Return None
end
Estimated code review effort2 (~12 minutes) Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
DZakh
commented
Jul 22, 2025
Comment on lines
+134
to
+138
| switch maxAllowedBlocksRegExp->Js.Re.exec_(message) { | ||
| | Some(execResult) => extractBlockRange(execResult) | ||
| | None => | ||
| switch blastPaidRegExp->Js.Re.exec_(message) { | ||
| | Some(execResult) => extractBlockRange(execResult) | ||
| switch baseRangeRegExp->Js.Re.exec_(message) { | ||
| | Some(_) => Some(2000) |
Member
Author
There was a problem hiding this comment.
It used to catch the base case before with 2000 range hardcoded.
JasoonS
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Bug Fixes
Tests