Improve failure message of contract import unhandled array types - #77
Merged
Merged
Conversation
JonoPrest
commented
Jul 17, 2024
Comment on lines
+1162
to
+1166
| EthAbiParamType::Tuple(_) => { | ||
| Err(anyhow!("Unhandled contract import type 'array of tuple'"))? | ||
| } | ||
| EthAbiParamType::Array(_) => { | ||
| Err(anyhow!("Unhandled contract import type 'array of array'"))? |
Collaborator
Author
There was a problem hiding this comment.
To be more clear about what is failing
JonoPrest
commented
Jul 17, 2024
Comment on lines
+1170
to
+1171
| let inner_type = Self::from_ethabi_type(abi_type) | ||
| .context("Unhandled contract import nested type in array")?; |
Collaborator
Author
There was a problem hiding this comment.
This recursion should not fail here actually since we error the unhandled cases above this but just a backup for changing code in future.
JonoPrest
commented
Jul 17, 2024
Comment on lines
-405
to
+408
| .context("converting eth event param to gql scalar")?, | ||
| .context(format!( | ||
| "Converting eth event param '{}' to gql scalar", | ||
| flattened_event_param.event_param.name | ||
| ))?, |
Collaborator
Author
There was a problem hiding this comment.
Add context of which param fails
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.