Fix Buffer.from for SharedArrayBuffer - #259
Merged
Merged
Conversation
|
@feross Do we have an expectation to get this through? Very helpful for those like me, working with SharedArrayBuffer. |
VictorQueiroz
approved these changes
Feb 26, 2020
Contributor
Author
|
@feross ? |
Owner
|
Published as 5.5.0. |
Contributor
Author
|
Thank you! (But I still don't see the version on npm) |
feross
added a commit
that referenced
this pull request
Mar 6, 2020
SharedArrayBuffer support originally added in #259
Owner
|
Note: Before publishing 5.5.0, I had to add back support for browsers which lack It's published now. |
Contributor
Author
|
👍 |
totorokop
pushed a commit
to totorokop/react-native-buffer
that referenced
this pull request
Aug 25, 2025
SharedArrayBuffer support originally added in feross/buffer#259
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #256
SharedArrayBufferhas the same properties asArrayBuffer(new Uint8Array(sab)works,sab.byteLengthexists), thereforefromArrayBuffercan be used.