[13.x] Guard against non-string mac in maintenance bypass cookie - #61314
Merged
taylorotwell merged 1 commit intoAug 24, 2026
Merged
taylorotwell merged 1 commit into
taylorotwell merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MaintenanceModeBypassCookie::isValid()checks that themacin the decoded cookie is set, but not that it's actually a string. If someone sends alaravel_maintenancecookie whosemacis an array,isset()still passes and the array is handed straight tohash_equals(), which throws aTypeError. While maintenance mode is active with a secret, that turns into an unauthenticated 500 instead of the expected 503.Reproduction, using an array for
mac:The fix swaps the
isset()check foris_string(), matching theis_numeric()guard already used forexpires_atright above it. A non-stringmacnow just fails validation and the request gets the normal 503.