Autoimport always imports relative to baseUrl

[mjbvz]

From Maksim Popov (@artaommahe) on November 9, 2017 11:38

• VSCode Version: 1.18.0
• OS Version: Windows 10

Steps to Reproduce:

1. ts project with provided baseUrl
2. add autoimport for smth from same directories sub-tree
3. see baseUrl relative import

/// auth/routing.ts
import {MobileStubComponent} from "auth/component/mobile-stub/mobile-stub";

expected import relative to current file

import {MobileStubComponent} from "./component/mobile-stub/mobile-stub";

Reproduces without extensions: Yes

Copied from original issue: microsoft/vscode#37928

[mjbvz]

From Sebastian Nemeth (@martaver) on November 9, 2017 20:17

Also seeing this behavior, in 1.18 and previous, on both manually chosen import fixes and the new auto-import on completion feature.

[mjbvz]

From Sebastian Nemeth (@martaver) on November 9, 2017 20:34

For me, removing the baseUrl entry from my tsconfig.json file fixed the issue.

[kumarharsh]

Matt Bierner (@mjbvz) would this issue also affect autoimport in JS/JSX? I'd have a few suggestions for the feature, but don't know if this is the correct place for it.

Kumar Harsh (@kumarharsh) Yes, they're the same feature.

[kumarharsh]

OK, so I found the feature useful, although a little rough to use because the import paths it produces are not how the rest of the code is written.

Many times, I export code from the index.js file, for example: constants/Widgets/index.js. Then, I import in this style:

import { A, B, C } from 'constants/Widgets';

• I drop the /index part because it's redundant in JS/TS-based systems, as far as I know.
• I also drop the extension part for JS files.
• I use webpack, and it has a nifty feature which let's me define custom module resolutions (resolve.modules)[https://webpack.js.org/configuration/resolve/#resolve-modules], so instead of writing ../../../ui/Input, I can just write ui/Input and keep my code clean. It also allows me to move the component somewhere else in the future without worrying about breaking import paths.

If the vscode solution can take these into account, it'd be awesome.

• For /index see Strip "/index" from import fix module specifiers #19962.
• We should be dropping the .js extension already.
• Setting up --rootDirs should make the third part work.