Fix for issue #39458 - #52506
Merged
Merged
Fix for issue #39458#52506
Conversation
…d off matching brackets
Contributor
Author
|
Johannes Rieken (@jrieken) Closed the previous PR #52259 (made a small mess). This one has the algorithm implemented with the changes you suggested in the previous PR. |
Johannes Rieken (jrieken)
added
the
editor-symbols
Contributor
|
lgtm. thanks Jason (@bitshiftza) |
Member
|
I did not manage to trigger As there are no tests for this code and the code is hard to read and undocumented, I removed it in 1d7f844. This helps me to refactor I'm sure the new bracket pair matching API would make this algorithm obsolete anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39458
Implemented algorithm for determining code preview popup content based off matching brackets.