Fix #35361: fix native tabs on macOS 10.13 - #52775
Merged
Benjamin Pasero (bpasero) merged 2 commits intoJun 25, 2018
Merged
Conversation
macOS 10.13 mistakenly enables a compatibility option on VS Code and VS Code Insiders because their bundle IDs begin with "com.microsoft.". This breaks native tabs. Explicitly disable the compatibility patch using NSUserDefaults. Note that Code-OSS is not affected by the bug, since its bundle ID is "com.visualstudio.code.oss". To test this behaviour, change darwinBundleIdentifier in product.json.
Aditya Dutt (nzec)
approved these changes
Jun 25, 2018
Jonathan Barronville (jonathanmarvens)
approved these changes
Jun 25, 2018
Contributor
|
zhuowei thanks ❤️ , I added a small adjustment to only set this when the |
Benjamin Pasero (bpasero)
added a commit
that referenced
this pull request
Jun 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS 10.13 mistakenly enables a compatibility option on VS Code and VS Code Insiders because their bundle IDs begin with "com.microsoft.". This breaks native tabs.
Explicitly disable the compatibility patch using NSUserDefaults.
Note that Code-OSS is not affected by the bug, since its bundle ID is "com.visualstudio.code.oss". To test this behaviour, change darwinBundleIdentifier in product.json.
See #35361 for more information.
Benjamin Pasero (@bpasero)