Skip to content

Can we remove inline onload handler to support script-src-attr: none #614

Description

@adrianbj

I think that onload="Tracy.Dumper.init()" in bar.js is the only thing conflicting with script-src-attr: none but I think a thorough scan for others would be wise.

Would you be willing to replace this with an eventListener?

While I was there, I removed the deprecated write()

		let doc = win.document;
		doc.open();
		doc.close();
		let charset = doc.createElement('meta');
		charset.setAttribute('charset', 'utf-8');
		doc.head.appendChild(charset);
		doc.body.id = 'tracy-debug';
		let s = doc.createElement('script');
		s.src = baseUrl + '_tracy_bar=js&XDEBUG_SESSION_STOP=1';
		s.async = true;
		s.addEventListener('load', function() { Tracy.Dumper.init(); });
		doc.head.appendChild(s);

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions