fix: handle multipart uploads without content-length - #16301
Merged
JarrodMFlesch merged 2 commits intoApr 16, 2026
Merged
Conversation
JarrodMFlesch
changed the title
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
JarrodMFlesch
enabled auto-merge (squash)
April 16, 2026 19:15
denolfe
approved these changes
Apr 16, 2026
JarrodMFlesch
deleted the
fix/payload-multipart-formdata-no-content-length
branch
April 16, 2026 19:29
This was referenced Apr 17, 2026
milamer
pushed a commit
to milamer/payload
that referenced
this pull request
Apr 20, 2026
## Summary
- accept multipart requests when a body stream is present even if
`Content-Length` is missing
- add base-case coverage for multipart eligibility and request parsing
without `Content-Length`
- wait for multipart parser completion before returning parsed files to
avoid temp-file race/empty-file reads
- stop forcing manual FormData `Content-Length` in the test REST client
helper
## What This Fixes
The Azure streaming upload MIME test intermittently failed because
multipart FormData requests could be skipped or race file reads in
certain no-`Content-Length` paths, producing empty-file upload behavior.
This test would fail:
```ts
TypeError: Cannot read properties of undefined (reading 'url')
❯ test/storage-azure/streamingUploads.int.spec.ts:61:56
59| })
60| ).json()
61| const response = await restClient.GET(newMedia.doc.url.replace(/^\…
| ^
62| expect(response.headers.get('content-type')).toEqual('image/png')
63| })
```
## Validation
- `pnpm exec vitest run
packages/payload/src/uploads/fetchAPI-multipart/isEligibleRequest.spec.ts
packages/payload/src/utilities/addDataAndFileToRequest.spec.ts`
- `pnpm exec vitest run --project int
test/storage-azure/streamingUploads.int.spec.ts -t "preserves mime type
when uploaded via rest endpoint"` (5 consecutive passes)
Contributor
|
🚀 This is included in version v3.84.0 |
This was referenced Aug 19, 2026
busbyk
added a commit
to NWACus/web
that referenced
this pull request
Sep 8, 2026
Bump payload and every @payloadcms/* package from 3.81.0 to 3.88.0 and remove the pnpm patches, which upstream has made redundant: - payload.patch (multipart bodies without Content-Length) shipped in 3.84.0 via payloadcms/payload#16301. Its regression test is deleted, as the note in that test asked for once we passed 3.84.0. - @payloadcms/storage-vercel-blob (allowOverwrite) is unconditional since 3.87.0 via payloadcms/payload#17385, so the plugin option goes. - @payloadcms/plugin-mcp: `instructions` is native since 3.84.0 (payloadcms/payload#15858). `authDepth` was never upstreamed, so the plugin's overrideAuth hook now re-fetches the API key's user at depth 2 before the MCP tools run RBAC checks with it. Regenerate types and the import map, document the overrideAuth hook and the 3.88 change that binds MCP API keys to their creator, and relink drift. No schema changes: migrate:create --skip-empty produced nothing. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Content-Lengthis missingContent-LengthContent-Lengthin the test REST client helperWhat This Fixes
The Azure streaming upload MIME test intermittently failed because multipart FormData requests could be skipped or race file reads in certain no-
Content-Lengthpaths, producing empty-file upload behavior.This test would fail:
Validation
pnpm exec vitest run packages/payload/src/uploads/fetchAPI-multipart/isEligibleRequest.spec.ts packages/payload/src/utilities/addDataAndFileToRequest.spec.tspnpm exec vitest run --project int test/storage-azure/streamingUploads.int.spec.ts -t "preserves mime type when uploaded via rest endpoint"(5 consecutive passes)