Skip to content

Translate jsx-in-depth to pt-BR - #105

Merged
jhonmike merged 6 commits into
reactjs:masterfrom
murtinha:translate-jsx-in-depth
Mar 9, 2019
Merged

Translate jsx-in-depth to pt-BR#105
jhonmike merged 6 commits into
reactjs:masterfrom
murtinha:translate-jsx-in-depth

Conversation

@murtinha

@murtinha murtinha commented Feb 18, 2019

Copy link
Copy Markdown
Contributor

References issue number #1

@halian-vilela halian-vilela added the needs review A pull request ready to be reviewed label Feb 18, 2019
negreirosleo
negreirosleo suggested changes Feb 18, 2019
View reviewed changes
Comment thread content/docs/jsx-in-depth.md Outdated
Comment thread content/docs/jsx-in-depth.md Outdated
Comment thread content/docs/jsx-in-depth.md Outdated
Comment thread content/docs/jsx-in-depth.md Outdated
Comment thread content/docs/jsx-in-depth.md Outdated
Comment thread content/docs/jsx-in-depth.md Outdated
Comment thread content/docs/jsx-in-depth.md Outdated
Comment thread content/docs/jsx-in-depth.md Outdated
Comment thread content/docs/jsx-in-depth.md Outdated
Comment thread content/docs/jsx-in-depth.md Outdated
michellocana
michellocana suggested changes Feb 18, 2019
View reviewed changes

@michellocana michellocana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adicionei várias sugestões, mas sem problemas, a maioria delas são somente erros ortográficos 😄

Comment thread content/docs/jsx-in-depth.md Outdated
Comment thread content/docs/jsx-in-depth.md Outdated
Comment thread content/docs/jsx-in-depth.md Outdated
Comment thread content/docs/jsx-in-depth.md Outdated
Comment thread content/docs/jsx-in-depth.md Outdated
Comment thread content/docs/jsx-in-depth.md Outdated
Comment thread content/docs/jsx-in-depth.md Outdated
Comment thread content/docs/jsx-in-depth.md Outdated
Comment thread content/docs/jsx-in-depth.md Outdated
Comment thread content/docs/jsx-in-depth.md Outdated
@halian-vilela halian-vilela added question Further information is requested needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 18, 2019
@halian-vilela

halian-vilela commented Feb 18, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

@negreirosleo @michellocana @murtinha

Pessoal, obrigado pelo review!

Percebi um certo impasse ali em relação à tradução de "syntactic sugar"

Em alguns lugares ficou "açúcar sintático" e em outros a expressão foi totalmente removida e substituída por "atalho".

Creio que como estamos sempre considerando a possibilidade do usuário ler a documentação oficial e se informar o suficiente para ler em outras fontes, eu particularmente não acho que seja uma boa remover completamente a expressão. Então a versão do "atalho" não seria adequada.

Como a expressão em português (açúcar sintático), apesar de feia, já tem inclusive verbete na Wikipedia, crio que podemos utilizá-la juntamente com a expressão original entre parênteses, apenas para fins de searchability.

O que acham então de decidirmos sobre - açúcar sintático (syntactic sugar) para a tradução oficial?

Me digam o que acham q subo uma PR pro Glossário.

@michellocana

michellocana commented Feb 18, 2019

Copy link
Copy Markdown
Contributor

Não sabia que "açúcar sintático" era uma tradução reconhecida e já estava na Wikipedia, sendo assim acho que podemos usá-la sim

@negreirosleo

negreirosleo commented Feb 18, 2019

Copy link
Copy Markdown
Contributor

@halian-vilela eu acho válido açúcar sintático (syntactic sugar), já vi pessoas em comunidades que participo usando o termo dessa forma (porém concordo tb que é meio feio kkkkkk).

@negreirosleo negreirosleo mentioned this pull request Feb 18, 2019
Merged
@murtinha
Apply suggestions from code review
a0c223e 
Co-Authored-By: murtinha <ericmurta@hotmail.com>
@murtinha
Some small translation changes
ab25520
michellocana
michellocana previously approved these changes Feb 19, 2019
View reviewed changes
@tesseralis tesseralis mentioned this pull request Feb 19, 2019
Closed
90 tasks
negreirosleo
negreirosleo previously approved these changes Feb 20, 2019
View reviewed changes
halian-vilela
halian-vilela suggested changes Feb 26, 2019
View reviewed changes
Comment thread content/docs/jsx-in-depth.md Outdated
@halian-vilela halian-vilela self-assigned this Feb 26, 2019
@halian-vilela @murtinha
Update content/docs/jsx-in-depth.md
f804a63 
Co-Authored-By: murtinha <ericmurta@hotmail.com>
@murtinha
murtinha dismissed stale reviews from negreirosleo and michellocana via f804a63 February 26, 2019 01:26
@netlify

netlify Bot commented Feb 26, 2019

Copy link
Copy Markdown

Deploy preview for pt-br-reactjs ready!

Built with commit f804a63

https://deploy-preview-105--pt-br-reactjs.netlify.com

@netlify

netlify Bot commented Feb 26, 2019 •
edited
Loading

Copy link
Copy Markdown

Deploy preview for pt-br-reactjs ready!

Built with commit ec6acee

https://deploy-preview-105--pt-br-reactjs.netlify.com

glaucia86
glaucia86 reviewed Mar 3, 2019
View reviewed changes

@glaucia86 glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@murtinha poucas mudanças a serem feitas. Realize as alterações listadas que o mais rápido possível estaremos aprovando a sua contribuição.

Muito obrigada! :)

Comment thread content/docs/jsx-in-depth.md Outdated
Comment thread content/docs/jsx-in-depth.md Outdated
Comment thread content/docs/jsx-in-depth.md Outdated
Comment thread content/docs/jsx-in-depth.md Outdated
Comment thread content/docs/jsx-in-depth.md Outdated
Comment thread content/docs/jsx-in-depth.md Outdated
Comment thread content/docs/jsx-in-depth.md Outdated
Comment thread content/docs/jsx-in-depth.md Outdated
@glaucia86 glaucia86 added needs review A pull request ready to be reviewed and removed question Further information is requested labels Mar 3, 2019
@glaucia86

glaucia86 commented Mar 3, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

@halian-vilela eu acho válido açúcar sintático (syntactic sugar), já vi pessoas em comunidades que participo usando o termo dessa forma (porém concordo tb que é meio feio kkkkkk).

Nesse caso, não tem como achar feio... pois no próprio wikipedia já define sobre o açúcar sintático. Cheguei a estudar sobre, nas aulas de algoritmo na Faculdade. Removendo a label question e incluindo aqui mais reviews para aprovar essa PR.

cc: @halian-vilela @eduardomoroni @cezaraugusto se puderem dar uma olhada nessa PR para que possamos aprovar o quanto antes :)

halian-vilela
halian-vilela previously approved these changes Mar 4, 2019
View reviewed changes
@halian-vilela

halian-vilela commented Mar 4, 2019

Copy link
Copy Markdown
Contributor

@halian-vilela eu acho válido açúcar sintático (syntactic sugar), já vi pessoas em comunidades que participo usando o termo dessa forma (porém concordo tb que é meio feio kkkkkk).

Nesse caso, não tem como achar feito... pois no próprio wikipedia já define sobre o açúcar sintático. Cheguei a estudar sobre, nas aulas de algoritmo na Faculdade. Removendo a label question e incluindo aqui mais reviews para aprovar essa PR.

cc: @halian-vilela @eduardomoroni @cezaraugusto se puderem dar uma olhada nessa PR para que possamos aprovar o quanto antes :)

Deixei aprovado, @glaucia86, eu já tinha feito uma revisão geral, então, assim que forem feitas as suas sugestões pode mergear!

Abraços!

@glaucia86

glaucia86 commented Mar 5, 2019

Copy link
Copy Markdown
Contributor

@murtinha só fazer as alterações necessárias que logo em seguida aprovaremos a sua excelente contribuição! :)

Quando concluir nos sinalize com cc: @glaucia86 ou @halian-vilela

@jhonmike jhonmike removed the needs review A pull request ready to be reviewed label Mar 6, 2019
@glaucia86 @murtinha
Update content/docs/jsx-in-depth.md
a289fad 
Co-Authored-By: murtinha <ericmurta@hotmail.com>
@murtinha
murtinha dismissed stale reviews from halian-vilela via a289fad March 8, 2019 12:06
@murtinha
Apply suggestions from code review
ec6acee 
Co-Authored-By: murtinha <ericmurta@hotmail.com>
@murtinha

murtinha commented Mar 8, 2019

Copy link
Copy Markdown
Contributor Author

Desculpa a demora @glaucia86 , estava viajando, Obrigado pelo review

@jhonmike jhonmike added needs review A pull request ready to be reviewed and removed needs author response Changes requested needing author's input labels Mar 8, 2019
@murtinha

murtinha commented Mar 9, 2019

Copy link
Copy Markdown
Contributor Author

@halian-vilela

glaucia86
glaucia86 approved these changes Mar 9, 2019
View reviewed changes

@glaucia86 glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@murtinha muito obrigada pela sua excelente contribuição!

LGTM 👍

cc: @halian-vilela @jhonmike só aprovar! :)

@glaucia86

glaucia86 commented Mar 9, 2019

Copy link
Copy Markdown
Contributor

bitmoji

cc: @murtinha muito obrigada pela sua contribuição.

cc: @halian-vilela @jhonmike só aprovar e mergear! :)

@glaucia86 glaucia86 added needs +1 Needs another approval before merging and removed needs review A pull request ready to be reviewed labels Mar 9, 2019
@jhonmike
jhonmike merged commit 69168a0 into reactjs:master Mar 9, 2019
@jhonmike jhonmike added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging labels Mar 9, 2019
devin-ai-integration Bot pushed a commit to WalissonRodrigo/pt-br.react.dev that referenced this pull request Jul 9, 2026
@murtinha Jhon Mike
Translate jsx-in-depth to pt-BR (reactjs#105)
d6400c9 
* Translate jsx-in-depth to pt-BR

* Apply suggestions from code review

Co-Authored-By: murtinha <ericmurta@hotmail.com>

* Some small translation changes

* Update content/docs/jsx-in-depth.md

Co-Authored-By: murtinha <ericmurta@hotmail.com>

* Update content/docs/jsx-in-depth.md

Co-Authored-By: murtinha <ericmurta@hotmail.com>

* Apply suggestions from code review

Co-Authored-By: murtinha <ericmurta@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhonmike jhonmike jhonmike approved these changes
+4 more reviewers
@glaucia86 glaucia86 glaucia86 approved these changes
@halian-vilela halian-vilela halian-vilela left review comments
@michellocana michellocana michellocana left review comments
@negreirosleo negreirosleo negreirosleo left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@halian-vilela halian-vilela

Labels

🌐 translated Translation is completed for this page

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@murtinha @halian-vilela @michellocana @negreirosleo @glaucia86 @jhonmike