Entries fieldtype augments to a query builder - #5238
Merged
Merged
Conversation
Previously it would only handle when they're not wrapped in a Value object. The first test was coverage for the existing thing, the second test is coverage for the fix.
jasonvarga
marked this pull request as ready for review
February 8, 2022 22:36
This was referenced Feb 11, 2022
This was referenced Mar 1, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #5201
The
entriesfieldtype previously augmented to anEntryCollectionofEntryobjects.Now, it'll augment to a query builder so you can continue to chain onto it and further refine your query.
Blade
This PR helps allow better fluent templating in Blade. See #5201.
Antlers
This PR makes Antlers handle query builders in more places. You can call the same methods that you would use on a
collectiontag.Unlike Blade or raw PHP, you don't have to call
->get()on the query. Antlers will know you intend to loop over the results of the query.Breaking change
This is a bit of a breaking change when using
entriesfieldtypes in Antlers.Previously, if you did:
...it would be applying the
foomodifier directly to the collection. But now it'll assume you're trying to modify the query.If you want to continue to just apply modifiers to the collection, you can use an alias and put your modifiers on the inner loop.